Basic Python3 support - Githubissues

nixprime / cpsm

A CtrlP matcher, specialized for paths.

Apache License 2.0

202 stars 19 forks source link

Basic Python3 support #23

Closed eapache closed 8 years ago

eapache commented 8 years ago

Addresses #22 on my machine. cc @burke

I don't expect this to get accepted as-is, but it compiles and runs using vim-with-python3 on my machine, so I figured it would be worth publishing as a first step.

Still todo:

[x] support both python2 and python3 dynamically in vimscript
[x] support both python2 and python3 dynamically in cmake based on vim --version
[x] figure out which versions of python3 are (easy/worth) supporting (I happened to have 3.5 so that's what I set in cmake)

eapache commented 8 years ago

OK, I believe this is ready to go; it switches on python 2 and 3 everywhere so it should be usable with either now.

nixprime commented 8 years ago

Thank you very much for the contribution, and sorry for the long hiatus!

nixprime commented 8 years ago

Looks good, thanks again!

maximsch2 commented 8 years ago

This actually breaks neovim setup that supports both python2 and python3 together. It looks like python 2 version is being built (as I don't have python3-dev installed), but then vim portion detects that python3 is available and decides to use it (but there is no package for python3 built!).

nixprime commented 8 years ago

Hi @maximsch2, can you try the current master?

maximsch2 commented 8 years ago

@nixprime I've tried it and it doesn't solve the issue (one thing is that it is calling vim in your script and at least for me neovim is nvim). I can solve it myself with PY3=ON now though, maybe python3-dev got installed somehow and now that the module is being built everything is working.

Is it possible to try calling both python2 and python3 versions in the cpsm.vim? That should solve the problem as it will work if at least one version of .so file was built.