search

nixprime / cpsm

A CtrlP matcher, specialized for paths.
Apache License 2.0
202 stars 19 forks source link

Use PythonLibs instead of PythonLibsCustom to fix lib detection problems (fixes #35) #36

Closed svenstaro closed 6 years ago

svenstaro commented 7 years ago

I think using PythonLibs is the proper way to do this. With PythonLibsCustom I had problems where it detected the wrong libraries (on Arch Linux). Additionally, by using the system-provided file, it will be maintained upstream which means less code for you to worry about. This also fixes #35.

svenstaro commented 6 years ago

@nixprime Hey, could you take a look?

nixprime commented 6 years ago

PythonLibsCustom exists since PythonLibs does not consistently work on Mac OS X (see https://github.com/nixprime/cpsm/commit/01e2392af323640674ef58134b26f8746bfad74a). I'll try to set up an Arch Linux VM to repro the original issue, but switching to PythonLibs altogether isn't an option.

svenstaro commented 6 years ago

Ok fair enough. How about we leave your custom script in and only run it in case we're on APPLE?

Shougo commented 6 years ago

Any progress?

vimeitor commented 6 years ago

Can confirm that this PR fixes the issue for me as well.

svenstaro commented 6 years ago

This has been fixed by @nixprime in some other way.

mrinterweb commented 6 years ago

I just updated to the latest version of cpsm, and I'm now getting the same error.