search

nixpulvis / galos

Elite: Dangerous Database and Tools
3 stars 0 forks source link

Dynamically Load Star Systems #24

Closed nixpulvis closed 3 months ago

nixpulvis commented 3 months ago

See #20.

nixpulvis commented 3 months ago

Found a bug. After searching for a star system, changing the spyglass radius doesn't trigger a fetch.

nixpulvis commented 3 months ago

Hilarious. Because Sol is at (0,0,0) and that's where I was testing this, it's the only place that fails and has nothing to do with the search (good). The reason for this is here: https://github.com/nixpulvis/galos/blob/6ee365a910f155a245220d210fdae040db652987/starmap/src/systems.rs#L115

When center is (0,0,0) dividing by scale doesn't change the region so nothing new loads. This will be fixed when I expand the definition for the elements of FetchTasks and LoadedRegions.

nixpulvis commented 3 months ago

This should be good to go I think. I'll probably do another read over it though before I merge.