nixpulvis / galos

Elite: Dangerous Database and Tools
3 stars 0 forks source link

Weird Issue Fetching #65

Closed nixpulvis closed 2 months ago

nixpulvis commented 2 months ago

Fetching while changing the index will trigger fetches at a rate determined by fetch_condition in this case last_fetch index is not the same as the current index.

However for a reason I cannot explain, when last_fetched == index when it's stopped changing. The last one doesn't get updated until the slower time delay.

Smells of an off by one error honestly

https://github.com/nixpulvis/galos/blob/1c3d5f9be11bc04bbf38d22f6af7991cfa5162c8/galos_map/src/systems/fetch.rs#L162-L175

nixpulvis commented 2 months ago

I think I figured it out! And why it's so intermittent .

I index the radius by int (on purpose), but I query by float, so we can think we're querying the same index, when there will actually be more results on the next fetch!

I think all we need to do is radius.floor() to grab the right thing.