search

nixpulvis / oursh

Your comrade through the perilous world of UNIX.
http://nixpulvis.com/oursh/oursh
MIT License
67 stars 6 forks source link

Repl #68

Open nixpulvis opened 1 year ago

nixpulvis commented 1 year ago

Specifically, this does not look to implement everything in #48, though I do hope to get completion working in a somewhat basic state before I move on to making things line up for the modern language. It's worth thinking about how this influences the design though.

The primary goal of this PR is to reintegrate the REPL module and start solidifying it. Unfortunately that means we are back to dealing with #20 which this reverts the partial fix for in a PR it should never have landed in to begin with: #51.

fixes #42 reopens #20

nixpulvis commented 1 year ago

First pass review done.

Overall, I think the only big open question is how to decouple Runtime from the repl and if we want to block this PR on that work.

Also, as usual, error handling could be better.