search

nixrajput / flutter_carousel_widget

A customizable Flutter carousel widget with infinite scrolling, auto-scrolling, pre-built indicators, expandable widgets, auto-sized child support, and enlarged center page.
https://pub.dev/packages/flutter_carousel_widget
MIT License
34 stars 20 forks source link

Add feature: customizable halo for prebuilt indicators #45

Closed ProV1X closed 2 months ago

ProV1X commented 2 months ago

This PR implements the feature mentioned in #44

ProV1X commented 2 months ago

Hi @nixrajput,

Thanks for the review! To clarify, the halo parameters are null by default, only appearing when specifically provided.

Could you elaborate on what you'd like added? Are you thinking of something like a boolean showHalo flag to easily toggle it on/off? Happy to implement your suggestion with more specifics!

nixrajput commented 2 months ago

Hi @ProV1X,

I hope you're doing well.

I believe incorporating a basic Halo design with a showHalo boolean option would be an excellent feature enhancement. Setting this option to true by default would ensure the halo is displayed unless explicitly turned off by the user, providing greater flexibility and control.

It would also be beneficial to document this property clearly for users who may want to disable the halo.

Thanks and regards,
Nikhil

ProV1X commented 2 months ago

Hi @nixrajput,

I've updated the implementation to consolidate slide indicator configuration into a SlideIndicatorOptions class. This simplifies the halo management and reduces code duplication, making the codebase cleaner and easier to maintain. It also lays a foundation for easier future extension of slide indicator features.

Please take a look and let me know your thoughts on the changes!

ProV1X commented 2 months ago

Hi @nixrajput,

Hope all is well! I'm just checking in on the status of this PR. Do you have an estimated timeline for when it might be reviewed/merged?

Thanks for your time!

nixrajput commented 2 months ago

Hi @ProV1X,

Thank you for the PR. I hope you are doing well. Nowadays, I am busy due to the transition of my job and some personal work, but I will merge and release this update ASAP.

Thanks and regards, Nikhil

ProV1X commented 2 months ago

No problem, @nixrajput! Congratulations on the new job and best of luck with everything. I'll look out for the merge when you have time.

Thanks for your work on the package!