nixys / nxs-backup

The tool for creating, delivering and rotating backups for GNU/Linux distributions.
https://nxs-backup.io
Apache License 2.0
256 stars 13 forks source link

.docker/mariadb/* #78

Open grooverdan opened 3 months ago

grooverdan commented 3 months ago

An easier format would be:

FROM nixyslab/nxs-backup-bin AS bin

FROM mariadb:10.11

COPY --from=bin /nxs-backup /usr/local/bin/nxs-backup

CMD nxs-backup start

When starting the container I got:

Can't find config by path '/etc/nxs-backup/nxs-backup.conf'. Would you like to create? (y/N): Failed to read configuration file: config error: open /etc/nxs-backup/nxs-backup.conf: no such file or directory

Its unclear of the purpose here. Are these demo files for inclusion and if so what is the usage?

So maybe include that configuration file in the build.

note: there's a few EOL versions here: ref: https://mariadb.org/about/#maintenance-policy

randreev1321 commented 3 months ago

Hi @grooverdan, thank you for reporting this issue.

This is a good point. In fact, nxs-backup requires a prepared config, which is missing from the image. The user should add it as a volume. This is probably worth adding to the documentation.

grooverdan commented 3 months ago

Declare /etc/nxs-backup/ are a VOLUME perhaps.