niyomja / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

oauth verifier of None should not get sent to the host... #117

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This is a problem with the python oauth bindings.  I have some code that
uses tokens that do not have verifiers, and in svn this causes problems
since None is getting sent in the URL to the host.  I'm guessing the
solution is either:

A) In OAuthRequest.from_consumer_and_token, only assign the verifier to
parameters IF verifier evaluates (e.g. if verifier: parameters['...)

OR

B) Skip over keys with values of None in OAuthRequest.to_header() and
OAuthRequest.to_postdata() ...

I'm using svn r1116

Original issue reported on code.google.com by ruib...@gmail.com on 24 Aug 2009 at 9:40

GoogleCodeExporter commented 9 years ago
I'm also having an issue with token.callback just above.  In my case, the token 
has a
key and a secret, but no callback nor verifier.

Original comment by ruib...@gmail.com on 24 Aug 2009 at 10:28

GoogleCodeExporter commented 9 years ago
The attached patch fixes this issue.

Original comment by dobey.p...@gmail.com on 8 Sep 2009 at 7:28

Attachments:

GoogleCodeExporter commented 9 years ago
Sorry, I didn't notice this bug report right away. It is fixed here:
http://code.google.com/p/oauth/source/detail?r=1124

Thanks!

Original comment by leah.culver on 17 Sep 2009 at 6:41

GoogleCodeExporter commented 9 years ago
This is not exactly fixed. This new patch fixes the code properly.

Original comment by dobey.p...@gmail.com on 24 Sep 2009 at 4:00

Attachments: