search

nizarmah / auto-minify

Minifies JS and CSS files in GitHub workflows.
GNU General Public License v3.0
48 stars 18 forks source link

Supporting JSON file minification #14

Open pilotkid opened 3 years ago

pilotkid commented 3 years ago

Hello, I have a project that has a few JSON files in it. Does this action support the modification of JSON files?

nizarmah commented 3 years ago

Hello @pilotkid! I'm really sorry for this really late response.

The action doesn't support the modification of JSON files.

At the moment, this change will require some significant effort on my end to search for an appropriate library to use for the minification of the JSON files or if I'll need to create a small command to grep all whitespaces and necessary minifications for JSON.

Accordingly, before implementing such a feature, I prefer to wait until more users request such a feature.

If you're still in need of JSON minification, feel free please to open a pull request and ping me for review 😃

stretch07 commented 2 years ago

@nizarmah how exactly do we vote? I'll add a thumbs-up reaction

nizarmah commented 6 months ago

Hey @stretch07. Yes, please, give a thumbs up to the original comment.

If you have any suggestions (maybe a discussion post), let me know.