search

nizarmah / auto-minify

Minifies JS and CSS files in GitHub workflows.
GNU General Public License v3.0
48 stars 18 forks source link

Update readme examples #18

Closed Spreeuw closed 3 years ago

Spreeuw commented 3 years ago

The version constraints in the readme examples are a little dated or not ideal I would suggest to make these changes:

stefanzweifel/git-auto-commit-action@v3.0.0

to:

stefanzweifel/git-auto-commit-action@v4

and your own:

nizarmah/auto-minify@master

I would change to

nizarmah/auto-minify@v2

(I would consider master to be more like the bleeding edge for people who need quick access to an unreleased fix, but stable releases more suitable for most people)

nizarmah commented 3 years ago

@Spreeuw you're right! Thanks for that! Back when I wrote the README, I included master without any regard to the importance of having actions not unexpectedly "break".

Regarding the git-auto-commit-action upgrade, sounds good as well 👍🏼 Would you prefer to open a pull request with those changes and have me review it? Or would you like me to create a pull request, while handling the review? Let me know 😃

I can also create a PR without your review, but a little bit of friction over PRs is beneficial for both parties involved 😉

nizarmah commented 3 years ago

Thanks for the review @Spreeuw and for the helpful suggestions 😃 I hope you have a nice day!