search

nizarmah / auto-minify

Minifies JS and CSS files in GitHub workflows.
GNU General Public License v3.0
48 stars 18 forks source link

Update docs examples with latest dependency versions #20

Closed nizarmah closed 3 years ago

nizarmah commented 3 years ago

Updates the docs examples in the README with the latest dependency versions, as suggested in #18.

nizarmah commented 3 years ago

Hello @Spreeuw 😄 I created a pull request, as you requested. Would you like to review this change?

I'll give you a bit of time to answer/review, until Wednesday August 18; then, I'll merge the changes.

nizarmah commented 3 years ago

Please note that there are some changes to the README in #19. The changes there match the current pull request. 👍🏼

Spreeuw commented 3 years ago

@nizarmah you mentioned here that you were planning to release v2.1 last Wednesday, is anything holding up the release?

nizarmah commented 3 years ago

@Spreeuw Yeah! Sorry about that. I was having power issues in my country, which obstructed some of my plans during those times I'm available for my open source work.

I'm doing that in the next hour. It's a high priority on my list 👍🏼

Spreeuw commented 3 years ago

Great, thank you so much for the release! One nitpick: Your release is named 'Add option for minified files to overwrite existing files' but that looks a bit strange in the 'releases' section: auto-minify-release-name

It's more common to include the version number in the release name/title, like github themselves do too: github-fetch-release-name

That also addresses another nitpick: Your release changelog doesn't show all changes, currently it only shows:

but it also includes:

(you may or may not want to include the docs change, that's up to you of course)

nizarmah commented 3 years ago

@Spreeuw

It's more common to include the version number in the release name/title, like github themselves do too

That's good to know! Thank you!

I never knew what to include in the Release Title. And lately due to my power/connection issues in my country, I haven't had the chance to educate myself on those aspects 😔

Your release changelog doesn't show all changes

Yeah, I tend to forget that other people are using my tools. I love open source, but I'm not used to having an audience 😅

I often leave my changelog empty, sadly. I'll do my best to take things more seriously now that my tools are being used by others.

Also, I really appreciate your help with this. There's a lot of stuff I don't know and I haven't been reading about because I haven't had much of an audience. Your comments are really helping push me into the right direction, during this time.

At the moment, unfortunately, I've been spread thin across real world issues, but once those are in the clear, I'll have more time to deliver better quality in my repositories 😃

Spreeuw commented 3 years ago

No worries at all, I really appreciate your work on this, just trying to contribute!

nizarmah commented 3 years ago

I'm glad you are @Spreeuw 🤗 Hope you have a wonderful day btw! 🚀