CSS minification in :not()

nizarmah / auto-minify

Minifies JS and CSS files in GitHub workflows.

GNU General Public License v3.0

48 stars 18 forks source link

Closed ShockedPlot7560 closed 7 months ago

ShockedPlot7560 commented 2 years ago

Currently, all spaces in the :not() function are removed, breaking most conditions. Example:

ul > li:not(.class ul > li, .another-class ul > li) {
        display: none;
}

will become :

ul>li:not(.classul>li,.another-classsul>li){display:none;}

nizarmah commented 7 months ago

Oh. I never had that use case.

Thanks for reporting it. I'll make sure to address it.

I need some time, though. Ironic, saying it after 2 years. I know.

nizarmah commented 7 months ago

Hey! Small update regarding this: the issue was with Clean CSS.

Clean CSS was updated in #40 which fixed this issue. Lightning CSS, added in #36, also resolves this issue.

I haven't created the release yet, but it'll resolve this issue. I'll update the thread by the end of this week when I do.

nizarmah commented 7 months ago

Hello again @ShockedPlot7560. Thanks again for reporting this btw!

I've released v3, which contains the fix. I'm closing this.

Don't hesitate to open a new issue if you run into any issues. This time I assure you the response time will be much better 😅.