search

nizarmah / auto-minify

Minifies JS and CSS files in GitHub workflows.
GNU General Public License v3.0
48 stars 18 forks source link

Mark action as failed on error in minification process #3

Closed C0pyR1ght closed 4 years ago

C0pyR1ght commented 4 years ago

I think it would be helpful to set the action as failed if for example a Parse error occurs during minification process because the scoped files are not actually minified and therefore the goal not reached.

Several Times I had some minor typos within the files to me minified that lead to a Parse error. Therefore the file was obviously not commited to the repo but the action was always marked as successfull which is very missleading. You have to manually dive through the action logs to discover the failed minification process.

nizarmah commented 4 years ago

Hello @C0pyR1ght ( :

You are totally right! I will get to work on that as soon as possible. Thank you for the issue and the recommendation :D

I'll keep track of this issue in my commits and pull requests so you can see the progress ( :

nizarmah commented 4 years ago

Alright, so here's a quick update. I implemented the code necessary. I just need to launch a Docker image and test it for myself. Once it passes the tests I want, I'll pull and update the action! ( :

nizarmah commented 4 years ago

Testing Log can be found in Auto-Minify-Test/Issues#3.

image

nizarmah commented 4 years ago

Alright, updated the action in the marketplace.

Use the latest version, v1.5 and it should work as you wish ( :

Thanks a lot for the recommendation!

nizarmah commented 4 years ago

Kindly let me know if there is anything other way I can improve the Action :smile: