search

nizhf / hoi-prediction-gaze-transformer

MIT License
21 stars 4 forks source link

Detector confidence value may be incorrect #10

Closed kuri122333 closed 1 month ago

kuri122333 commented 1 month ago

Thank you for the great repo! I checked the run.py and found one area that I think you should check.

File "hoi-prediction-gaze-transformer/modules/object_tracking/yolov5_deepsort.py", line 183, for out, conf in zip(deepsort_outs, confs):

In the above section, “deepsort_outs” are sorted ID from the object tracker, while “confs” are not sorted with refer to the "deepsort_outs". I think there are mismatches.

Although this could be my misunderstanding, could you check it?

Thanks in advance.

nizhf commented 1 month ago

Thank you for your comments. Yes, I think you are right. The confs here do not match the tracker results.

A quick workaround is maybe to add a line after this https://github.com/nizhf/hoi-prediction-gaze-transformer/blob/main/modules/object_tracking/deep_sort/deep_sort.py#L49 like conf = det.confidence and append conf to the output list (L55). Then here https://github.com/nizhf/hoi-prediction-gaze-transformer/blob/main/modules/object_tracking/yolov5_deepsort.py#L192 you can change the source of confidence_list to the corresponding part in the out.

kuri122333 commented 1 month ago

I understood! Thanks for the feedback. I will try it.