njallskarp / finetune-qa-powerset

Finetuning BERT models on a powerset of different linguistic domains
https://lvl.ru.is/
5 stars 0 forks source link

Feat/training-datasets #9

Closed Eysteinn-Orn closed 1 year ago

Eysteinn-Orn commented 1 year ago

added 1 folder, 2 files: "init.py" and "config.py" and a small class to init.py. Config.py my be unnecessary at the current time.

Eysteinn-Orn commented 1 year ago

organized imports*

lsig commented 1 year ago

I was wondering if you could format the docstrings so they are inline, otherwise looks good. Maybe I can setup a formatter.

Eysteinn-Orn commented 1 year ago

@lsig what is the type for encodings?

Eysteinn-Orn commented 1 year ago

Collaborator @lsig https://github.com/njallskarp/finetune-qa-powerset/pull/9#issuecomment-1609587840 are you talking about docstring comments beginning like this:


"""Some text begins here

Args: The arguments

Returns: arguments added together """