njasm / container

Dependency Container / Service Locator for PHP
20 stars 2 forks source link

Composer require php 5.3 or 5.4 #34

Closed prisis closed 9 years ago

prisis commented 9 years ago

@njasm it should work like this, but i need some testing...

21

njasm commented 9 years ago

travis says no. https://travis-ci.org/njasm/container/jobs/44549854 :\

prisis commented 9 years ago

I might have an idea ;)

prisis commented 9 years ago

we can use something like this https://github.com/silexphp/Silex/blob/1.2/.travis.yml and install aura as extra or we make 2 branches for 5.3 and 5.4

njasm commented 9 years ago

the travis.yml file solution is really cool.. I like that we may try it out.. we have the aura/di in the required-dev, and remove the line if the env is PHP lower than 5.4

sed 's/aura\/di{*}//g' might work, didn't test it yet.

prisis commented 9 years ago

I can write a script for composer.json, which do the same thing, hmm I will try this

njasm commented 9 years ago

@prisis ok cool, in the meanwhile if you think you have found a better solution don't hesitate to share it.

njasm commented 9 years ago

@prisis does your pull request is the solutions for this issue? did you have the chance to test it ?

prisis commented 9 years ago

hey @njasm, i didnt have a chance to test it... And PHP5.3 is dead , that's why I closed it.

njasm commented 9 years ago

@prisis yes, your right. it's time to drop 5.3 support for good.

thanks for the notice!