Implement crop node - Githubissues

leoschwarz commented 3 years ago

Hello. This commit would implement a basic crop node, which was requested in #41.

The second commit introduces additional features which I'm not sure if you want them:

Customizable background color
Invert crop for cases where prop_min > prop_max (i.e. prop_min_x=0.6 prop_max_x=0.2 would keep x<=0.2 || x>=0.6). I was thinking about how to prevent this kind of user input, but maybe it can even be useful to have this sort of inverted crop available.

Let me know if there's something I should change.

njbrown commented 3 years ago

Hey, sorry for the late reply to this. Give me another day to review please.

njbrown commented 3 years ago

Excellent node!

I made a few changes, however:

renamed the display name for the properties
added clamp properties for x and y axes (and one for both)
moved the node to the v3 folder

I should have documented how I implement libraries. Node libraries are fixed in order to prevent existing textures from breaking or older versions of TL breaking when new nodes are added. This means once a new library is out the public, it's immutable. This crop node will be added to the next library version (v3) and released in the next major upcoming TL release (0.4.0). Sadly, that release wont be out until a few months because I have quite a few minor releases to make along the way.

Sorry if you were excited about seeing this new node in the next build. The rules around node libraries is a small sacrifice to pay to prevent a world of headaches between releases.

Thanks for your contribution again @leoschwarz !

njbrown / texturelab

Implement crop node #42