njbrown / texturelab

Free, Cross-Platform, GPU-Accelerated Procedural Texture Generator
Other
735 stars 45 forks source link

Export feature produces invalid zip #6

Closed tpotancok closed 4 years ago

tpotancok commented 4 years ago

Environment: Linux Mint 19.3 64-bit (Cinnamon) Version: 0.1.0 Description: When I'm trying to open the exported texture zip and not all channels are defined, the zip file comes out invalid (unreadable) for the GNOME archive manager. It looks like you're using a binary export instead of the proper library or Electron abstraction layer.

Btw you should really set up issue templates. It makes them way more readable and manageable.

njbrown commented 4 years ago

I did notice the issue on windows but the OS's zip exporter (and 7zip even) still extracted the files, though with a warning.

It looks like you're using a binary export instead of the proper library or Electron abstraction layer.

What do u suggest i use?

Btw you should really set up issue templates. It makes them way more readable and manageable.

Thanks. I will.

tpotancok commented 4 years ago

You can use any of the node.js libraries (JSZip looks like the best).

On Mon, Mar 9, 2020, 04:07 Nicolas Brown notifications@github.com wrote:

I did notice the issue on windows but the OS's zip exporter (and 7zip even) still extracted the files, though with a warning.

It looks like you're using a binary export instead of the proper library or Electron abstraction layer.

What do u suggest i use?

Btw you should really set up issue templates. It makes them way more readable and manageable.

Thanks. I will.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/njbrown/texturelab/issues/6?email_source=notifications&email_token=AJRTKIBD2LY2TEJ5JRIMWP3RGRMONA5CNFSM4LD3B2UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOFPWEY#issuecomment-596310803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRTKICGWB6AL4OOUYDPRMTRGRMONANCNFSM4LD3B2UA .

njbrown commented 4 years ago

I did initially, but it had a bug that forced me to switch to adm-zip

njbrown commented 4 years ago

This issue is now fixed a8eaeb96bb614d298071a13e0b1f66f244f26370