search

njcrawford / EmbroideryReader

Open source .PES file viewer
GNU General Public License v2.0
39 stars 20 forks source link

Installer sometimes leaves old versions behind after upgrade #15

Closed njcrawford closed 8 years ago

njcrawford commented 8 years ago

A user has reported that multiple versions show up in Programs and Features after upgrading to beta 2.2.1. It appears that the MajorUpgrade element in the installer is not working quite as intended. Need to figure out a way to reproduce this, since it seems to work correctly on my PC.

njcrawford commented 8 years ago

Probably not a problem we can fix... according to this article, this issue can happen if version 1 is installed per-user ("Just me") and the version 2 upgrade is run as per-machine ("Everyone"). Version 2.0 and 2.1 offered the option to choose which way to install it, but the new installer in 2.2 defaults to per-machine, with no option to change it.

(The new installer should fall back to per-user if the user doesn't have rights to install per-machine, but I suspect that will be a rare occurrence, given than most users are installing on a personal PC.)

The article also mentions a way to fix this problem by detecting how the previous version was installed, but it involves a custom action dll. That requires a lot more effort than I'm willing to put in right now. More details on the custom action dll in part 2 of the article.