njcrawford / EmbroideryReader

Open source .PES file viewer
GNU General Public License v2.0
42 stars 21 forks source link

add view realist in embroidery reader #22

Open fabricocouto opened 2 years ago

fabricocouto commented 2 years ago

add view realist in embroidery reader remove fill trim and jumps in designer

image

njcrawford commented 2 years ago

Hi @fabricocouto, I'm not sure I understand. Are you asking me to implement a realistic view in Embroidery Reader? Or are you saying you have written code that implements a realistic view?

fabricocouto commented 2 years ago

hello I wrote, do you want to implement?

njcrawford commented 2 years ago

Is your code posted somewhere I can look at it?

fabricocouto commented 2 years ago

https://github.com/fabricocouto/EmbroideryReader/commit/56e693ce308e9f4fe688112d1aa55222c07d75fc

fabricocouto commented 2 years ago

also correct the offset which must be pecstart + 28

njcrawford commented 2 years ago

Very interesting! Thank you for sharing. I would like to merge some parts of the code, is that ok?

fabricocouto commented 2 years ago

Yes Yes

njcrawford commented 2 years ago

Thank you!

njcrawford commented 2 years ago

also correct the offset which must be pecstart + 28

Is this number found by analyzing PES files or do you have a more official source?

fabricocouto commented 2 years ago

this error happens in some embroidery files pes saved by wilcom now i know together with my friend David the reason for the errors, you can see this error in more detail in the image in the image i put it pecstart 533 correct but actually it is not they, are 532 , I have been working on these codes for many years now I can clearly say that pecstart + 532 is wrong for some files and pecstart 528 opens all files the discovery of this error is official and most of the active repositories here about embroidery have already corrected it

image