search

njcrawford / EmbroideryReader

Open source .PES file viewer
GNU General Public License v2.0
39 stars 20 forks source link

Gibberish images are displayed on some PCs #8

Closed njcrawford closed 6 years ago

njcrawford commented 8 years ago

Some PCs seem to display gibberish when any file is loaded in version 2.0+, where they apparently worked just fine in 1.5.1.

So far, I'm have aware of 2 cases, one is Windows 8.1 with Norton AV installed, the other is Windows XP with AVG Free installed.

gibberish and crash

gibberish gibberish2

njcrawford commented 8 years ago

Note: the unhandled exception in the first image is unrelated and already fixed in an earlier version.

njcrawford commented 8 years ago

In the case of the Windows XP system, an older version (probably 1.5.1) worked properly and rendered designs correctly. Beta version 1.6.0 also renders correctly. (1.6.0 contains 1.5.1 code rebuilt and packaged in the 2.0 installer)

After further reviewing render code differences between version 1.5.1 and 2.1.0, the only significant difference appears to be the use of Graphics.DrawLines() in 1.5.1 vs Graphics.DrawLine() in a foreach loop in 2.1.0. Beta version 2.2.0 includes a change to use DrawLines() again.

It's not yet clear if beta 2.2.0 fixes this issue.

njcrawford commented 6 years ago

I haven't heard back from the person experiencing this issue and haven't been able to reproduce it myself.