search

njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)
MIT License
12 stars 1 forks source link

pol_spirou no longer runs on 0.6.101 #639

Closed cusher closed 4 years ago

cusher commented 4 years ago

The polar code looks for constants in the calculate_continuum function:

    pol_binsize = pcheck(params, 'POLAR_CONT_BINSIZE', 'pol_binsize', kwargs,
                         func_name)
    pol_overlap = pcheck(params, 'POLAR_CONT_OVERLAP', 'pol_overlap', kwargs,
                         func_name)

that were removed in this commit.

If there is going to be another version released before the updated polar recipe is integrated, it would be nice to put the constants back in (or even just hard code them for now) to at least allow runing the outdated recipe for testing purposes.

njcuk9999 commented 4 years ago

yer I recall saying I was pretty sure some of pol_spirou would break... I intended to add the new polar recipe all in one go but it hasn't been as simple as that. My only problem with adding these back in is keeping track of them until I have to remove them (same with functionality that is slightly different between the old polar code and new polar code) TODO statements would work but I have a worrying amount of them already.

I will add these back in but as I also said previously the old polar code has not been run at all (even before the new changes) so I'm not sure how stable it is or of the results it will give.

cusher commented 4 years ago

Assuming the new polar recipe isn't already close to being ready, here's one minor change to avoid crashes on the existing version. Not all that critical in any case.

https://github.com/njcuk9999/apero-drs/compare/polar_lsd_crashes