No file definition for LFC_FP

njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)

MIT License

12 stars 1 forks source link

No file definition for LFC_FP #641

Closed cusher closed 4 years ago

cusher commented 4 years ago

Some files (LFC_FP) are failing to preprocess. Adding the following to file_definitions.py allows them to pass:

raw_lfc_fp = drs_finput('RAW_LFC_FP', KW_CCAS='pos_rs', KW_CREF='pos_fp',
                         filetype='.fits', suffix='', KW_OBSTYPE='ALIGN')
raw_file.addset(raw_lfc_fp)

pp_lfc_fp = drs_finput('LFC_FP', KW_DPRTYPE='LFC_FP',
                        filetype='.fits', suffix='_pp', intype=raw_lfc_fp,
                        inext='.fits', outfunc=out.general_file)
pp_file.addset(pp_lfc_fp)

njcuk9999 commented 4 years ago

That's probably because no one told me LFC_FP existed!

Do you have a list anywhere of all the different (used) combinations of fibers - it would be really helpful when new ones are added to inform the DRS team.

cusher commented 4 years ago

Yep, I had a feeling you were unaware of this one. Took a look through things, and this is the only combination that's used that isn't already handled, as far as I know. At least, currently for science nights... @pfouque58 might have a better idea if there are more combinations that are planned to be added, or are used for engineering or that sort of thing?

pfouque58 commented 4 years ago

I think this is the only one that was missing. In the future we may want to use FP_LFC (FP on AB, LFC on C), LFC_HC, HC_LFC, but I don't think it is necessary to add them now. When/if JF asks for this kind of exposure, we will let you know.