search

njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)
MIT License
12 stars 0 forks source link

obj_mk_tellu_db fails for telluric stars #653

Closed pfouque58 closed 2 years ago

pfouque58 commented 3 years ago

Reducing a single night, the telluric correction was not run for the two telluric standards of that night. Maybe it is intended?

From the log of obj_mk_tellu_db:

13:58:21.577- |MKTELLDB[00412]| 13:58:21.648- |MKTELLDB[00412]|A[40-503-00013]: obj_mk_tellu_spirou.py 20AQ02-Feb04 2468585o_pp_e2dsff_AB.fits --program=DBMKTELLU1 13:58:21.990- |MKTELLDB[00412]|A[90-503-00005]: Skip Check: not skipping as SKIP_MKTELL not in params (unset) 13:58:22.065- |MKTELLDB[00412]|A[40-503-00005]: run ID00000 validated 13:58:22.140- |MKTELLDB[00412]| 13:58:22.213- |MKTELLDB[00412]|A[40-503-00004]: 13:58:22.216- |MKTELLDB[00412]|Validating run ID00001 (2 of 2) 13:58:22.282- |MKTELLDB[00412]| *** 13:58:22.355- |MKTELLDB[00412]|A[40-503-00013]: obj_mk_tellu_spirou.py 20AQ02-Feb04 2468606o_pp_e2dsff_AB.fits --program=DBMKTELLU1 13:58:22.671- |MKTELLDB[00412]|A[90-503-00005]: Skip Check: not skipping as SKIP_MKTELL not in params (unset) 13:58:22.738- |MKTELLDB[00412]|A[40-503-00005]: run ID00001 validated 13:58:22.809-|MKTELLDB[00412]|I[40-503-00016]: Running with 1 core 13:58:22.879-|MKTELLDB[00412]|ID00000| obj_mk_tellu_spirou.py 20AQ02-Feb04 2468585o_pp_e2dsff_AB.fits --program=DBMKTELLU1 13:58:53.433-|MKTELLDB[00412]|ID00001| obj_mk_tellu_spirou.py 20AQ02-Feb04 2468606o_pp_e2dsff_AB.fits --program=DBMKTELLU1 13:59:22.558-@|MKTELLDB[00412]|W[00-001-00043]: Internal error in recipe obj_mk_tellu_spirou.py. Controller recipe (obj_mk_tellu_db_spirou) cannot continue 13:59:22.672-|MKTELLDB[00412]|I[40-503-00011]: Generating run list 13:59:22.762- |MKTELLDB[00412]|A[40-503-00014]: Loading recipe module files... 13:59:27.067-*|MKTELLDB[00412]|I[40-503-00015]: Validating all runs (2 run ids found) 13:59:27.176- |MKTELLDB[00412]| ***

njcuk9999 commented 3 years ago

I'll be honest I haven't checked the mk_tellu_db and fit_tellu_db recipes in a while - it could be that currently they don't work.

Quick fix: use the limited_seq (as presented in the mini_run.ini) you'll note you can use SCIENCE_TARGETS = 'All' now so actually you have no need of mk_tellu_db or fit_tellu_db.

I will add fixing them to my todo list (but later) and if not I will just remove them as recipes.

pfouque58 commented 3 years ago

I checked that using the mini_run.ini script indeed works. So there is something buggy in mk_tellu_db for the telluric stars and in fit_tellu_db for the RV standards