njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)
MIT License
12 stars 0 forks source link

Remove calls to deprecated `DataFrame.append()` method from Pandas #693

Closed vandalt closed 1 year ago

vandalt commented 1 year ago

I got this warning message when running apero_astrometrics.py

/cosmos99/nirps/apero-bin/apero-drs/apero/tools/module/database/drs_astrometrics.py:1133: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
  dataframe = dataframe.append(astro_obj.to_dataframe())

EDIT: warning, not error

njcuk9999 commented 1 year ago

Error or a warning? It worked fine in the apero-env environment on nirps-client. Where are you using it?

vandalt commented 1 year ago

Warning, sorry, I updated my comment above. Also this is the related Pandas announcement (with new recommended syntax): https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append

njcuk9999 commented 1 year ago

I've updated this now.