njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)
MIT License
12 stars 0 forks source link

[APERO] mini data are not consistent #708

Open njcuk9999 opened 1 year ago

njcuk9999 commented 1 year ago

We see inconsistencies between minidata2 reductions in spirou.

rms of difference spirou@rali-cook@jupiter = 0.06417200529342021 m/s rms of difference spirou@rali-cook@nb19 = 0.1346402795169976 m/s rms of difference spirou@rali-spirou@maestria = 0.14235515258684286 m/s rms of difference spirou@rali-lam = 0.06417200529342021 m/s rms of difference spirou@rali-cfht = 0.9038638383785134 m/s

Image

Note this issue is also mentioned here: https://docs.google.com/document/d/1C8dp_5KuBfiumSGRzSTI1guZFvJkILOGYjmmvuK-6_c/edit?usp=sharing

clairem789 commented 1 year ago

here's a new link to Toulouse data for this minidataset: https://mycore.core-cloud.net/index.php/s/3cIsdql4lH3JqhV thanks!

njcuk9999 commented 1 year ago

Thanks I've downloaded it. I'll run LBL on it today and add a graph here when done.

njcuk9999 commented 1 year ago

So newworlds (as with previous versions) agrees very well with one group of the machines.

image

And a zoom in:

image

rms of difference spirou@rali-cook@jupiter = 0.06417200529342021 m/s rms of difference spirou@rali-cook@nb19 = 0.1346402795169976 m/s rms of difference spirou@rali-spirou@maestria = 0.14235515258684286 m/s rms of difference spirou@rali-newworlds = 0.13698797905443139 m/s rms of difference spirou@rali-lam = 0.06417200529342021 m/s rms of difference spirou@rali-cfht = 0.9038638383785134 m/s

So we have:

clairem789 commented 1 year ago

Interesting results! I wonder what this bimodality reflects. Can you please remind us on which machine the full reduction is run at UdM (rali, jupiter, maestria, nb19?)?

njcuk9999 commented 1 year ago

The full run is on rali. And yep I'm equally interested/perplexed by this bimodality.

At one point @eartigau suggested it could be the CCF we do at the start in LBL "jumping" onto a certain solution for the sys vel but I'm not sure this could still be true.

I think the best way would be to have someone (with time) take a tar of the full mini data sets from all of these and work backward (start at the tcorr, then the extract, then the calibs, then pp) and see where the difference comes from.

If the tcorr are the same to ~numerical accuracy it has to come from LBL.

In addition to this maestria and rali use the same user account (spirou) so they actual share the same disk, same python files, same github files, exactly the same mini data, which makes it even more bizarre that this disagrees (the only thing that differs is physical CPUs/RAM etc they were using (and the OS they are running I guess?)

larnoldgithub commented 1 year ago

Neil I just sent you a link to a new set of blaze+tcorr from a new mini_run2 test I did yesterday night after a apero_reset and apero_precheck.

I plotted the difference between 2 blaze or 2 tcorr files from before and after the reset and I see differences, so maybe now the cfht data fits the results from other machines.

njcuk9999 commented 1 year ago

Interesting, I'll add this data today. If it does agree with the other machines we really need to understand what happened between the restart. I'll post here when I have the data added to the graph.

njcuk9999 commented 1 year ago

Yep so CFHT agrees well now. So the question is what was the difference? We might have to ask Chris what could have changed as that is really perplexing.

Here is the new graph:

image

rms of difference spirou@rali-cook@jupiter = 0.06417200529342021 m/s rms of difference spirou@rali-cook@nb19 = 0.1346402795169976 m/s rms of difference spirou@rali-spirou@maestria = 0.14235515258684286 m/s rms of difference spirou@rali-newworlds = 0.13698797905443139 m/s rms of difference spirou@rali-lam = 0.06417200529342021 m/s rms of difference spirou@rali-cfht = 0.06658835428246165 m/s

I'm glad there are now only two sets, I still don't understand that or why CFHT data changed after a reset! :man_shrugging:

larnoldgithub commented 1 year ago

Screenshot 2023-08-13 at 21 36 01 Here is a map of the difference between a given blaze taken before and after the reset. The difference is not 0 and increases towards the K-band, where the blazes have a shape which is less symetrical. I understand that the polynomial involved into the blaze flux model is only up to 3rd order, but maybe the non-orthogonality between terms is the culprit for differences we see from one redcution to the next or between different machines?

larnoldgithub commented 1 year ago

Differences are low frenquecies, and likely to be described well with a polynomial up to degree 3.

larnoldgithub commented 1 year ago

What I'll do today is another reset on apikipiha and run again the mini_run2, to verify that what I get is consistent.

UPDATE: after a second apero_reset I do find exactly the same values: differences between blaze or between tcorr are 0. difference-after-2nd-reset-blaze-Screenshot 2023-08-14 at 15 48 10

larnoldgithub commented 1 year ago

The results after this second apero-reset suggest that a given machine finds always the same fit for a the blaze. But what about different machines ? Maybe Neil you could check for any differences in the blazes you got from the different reductions in marseille, toulouse, montreal and cfht ?

njcuk9999 commented 1 year ago

Yer I'll try checking these tomorrow. Correct me if I'm wrong though but your two results are from the same machine (before and after reset?) so do we have any idea what the difference was?

njcuk9999 commented 1 year ago

So I went through all 7 machines. And the difference is tiny. The fluxes we are talking for the blaze are ~80000 to 100000.

The biggest difference I see is on order 10 with a max diff of 0.6 at the edge of the blaze (around a flux of 5000)

Seems to only be cfht out this far on this particular order and all others agree much better: image

All other orders look like this with all not agreeing exactly but all agreeing quite well (within 0.03 flux on 60000) image

njcuk9999 commented 1 year ago

If you are interested in the full set of values they are here:

diff = blaze[spirou@rali] - blazer[other]

Order 0
    spirou@rali        max diff = 0.00000   flux at max diff = 4642.94805   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00948   flux at max diff = 1184.43571   frac diff = 8.00169e-06
    cook@nb19          max diff = 0.00913   flux at max diff = 1184.43537   frac diff = 7.71064e-06
    spirou@maestria    max diff = -0.00263   flux at max diff = 1184.42360   frac diff = -2.22428e-06
    newworlds          max diff = 0.00961   flux at max diff = 1184.43584   frac diff = 8.11181e-06
    lam                max diff = 0.00948   flux at max diff = 1184.43571   frac diff = 8.00169e-06
    cfht               max diff = 0.00903   flux at max diff = 1184.43526   frac diff = 7.62477e-06

Order 1
    spirou@rali        max diff = 0.00000   flux at max diff = 1611.96296   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00322   flux at max diff = 1611.95974   frac diff = -1.99535e-06
    cook@nb19          max diff = -0.00014   flux at max diff = 12869.19095   frac diff = -1.12483e-08
    spirou@maestria    max diff = -0.00360   flux at max diff = 1611.95936   frac diff = -2.23531e-06
    newworlds          max diff = 0.00245   flux at max diff = 7490.83215   frac diff = 3.27403e-07
    lam                max diff = -0.00322   flux at max diff = 1611.95974   frac diff = -1.99535e-06
    cfht               max diff = 0.00137   flux at max diff = 1611.96433   frac diff = 8.48484e-07

Order 2
    spirou@rali        max diff = 0.00000   flux at max diff = 2051.77252   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.02422   flux at max diff = 2051.79674   frac diff = 1.18062e-05
    cook@nb19          max diff = -0.01318   flux at max diff = 2051.75934   frac diff = -6.42207e-06
    spirou@maestria    max diff = -0.00227   flux at max diff = 52656.52240   frac diff = -4.30310e-08
    newworlds          max diff = 0.00554   flux at max diff = 50222.44843   frac diff = 1.10257e-07
    lam                max diff = 0.02422   flux at max diff = 2051.79674   frac diff = 1.18062e-05
    cfht               max diff = 0.00001   flux at max diff = 2051.77253   frac diff = 5.12000e-09

Order 3
    spirou@rali        max diff = 0.00000   flux at max diff = 9514.14487   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00786   flux at max diff = 29489.35636   frac diff = -2.66503e-07
    cook@nb19          max diff = -0.00121   flux at max diff = 36561.91706   frac diff = -3.29591e-08
    spirou@maestria    max diff = 0.00062   flux at max diff = 43080.06826   frac diff = 1.43775e-08
    newworlds          max diff = -0.00671   flux at max diff = 30365.20683   frac diff = -2.20819e-07
    lam                max diff = -0.00786   flux at max diff = 29489.35636   frac diff = -2.66503e-07
    cfht               max diff = 0.00041   flux at max diff = 40405.49354   frac diff = 1.02530e-08

Order 4
    spirou@rali        max diff = 0.00000   flux at max diff = 11234.03318   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00599   flux at max diff = 4837.06598   frac diff = -1.23829e-06
    cook@nb19          max diff = 0.00059   flux at max diff = 4702.42991   frac diff = 1.25135e-07
    spirou@maestria    max diff = 0.00027   flux at max diff = 4702.42959   frac diff = 5.68905e-08
    newworlds          max diff = -0.00272   flux at max diff = 72787.91138   frac diff = -3.73812e-08
    lam                max diff = -0.00599   flux at max diff = 4837.06598   frac diff = -1.23829e-06
    cfht               max diff = -0.00399   flux at max diff = 72922.60537   frac diff = -5.47768e-08

Order 5
    spirou@rali        max diff = 0.00000   flux at max diff = 12665.73623   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00002   flux at max diff = 49874.46441   frac diff = -3.66372e-10
    cook@nb19          max diff = 0.00001   flux at max diff = 81195.93146   frac diff = 7.89144e-11
    spirou@maestria    max diff = -0.00002   flux at max diff = 59310.27023   frac diff = -3.01661e-10
    newworlds          max diff = 0.00000   flux at max diff = 80387.99485   frac diff = 3.10782e-11
    lam                max diff = -0.00002   flux at max diff = 49874.46441   frac diff = -3.66372e-10
    cfht               max diff = -0.00003   flux at max diff = 56581.48574   frac diff = -6.13663e-10

Order 6
    spirou@rali        max diff = 0.00000   flux at max diff = 13256.25417   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.01064   flux at max diff = 51109.23791   frac diff = 2.08233e-07
    cook@nb19          max diff = 0.00852   flux at max diff = 50557.70720   frac diff = 1.68498e-07
    spirou@maestria    max diff = 0.01963   flux at max diff = 49926.28320   frac diff = 3.93179e-07
    newworlds          max diff = 0.00725   flux at max diff = 50005.26079   frac diff = 1.44926e-07
    lam                max diff = 0.01064   flux at max diff = 51109.23791   frac diff = 2.08233e-07
    cfht               max diff = 0.03277   flux at max diff = 58076.77754   frac diff = 5.64278e-07

Order 7
    spirou@rali        max diff = 0.00000   flux at max diff = 13856.88754   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.11455   flux at max diff = 74526.52225   frac diff = -1.53703e-06
    cook@nb19          max diff = 0.00425   flux at max diff = 13856.89179   frac diff = 3.06634e-07
    spirou@maestria    max diff = -0.11293   flux at max diff = 72632.20336   frac diff = -1.55483e-06
    newworlds          max diff = -0.00019   flux at max diff = 13856.88734   frac diff = -1.39435e-08
    lam                max diff = -0.11455   flux at max diff = 74526.52225   frac diff = -1.53703e-06
    cfht               max diff = 0.01245   flux at max diff = 79123.21240   frac diff = 1.57293e-07

Order 8
    spirou@rali        max diff = 0.00000   flux at max diff = 7056.66149   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.08375   flux at max diff = 96940.69967   frac diff = -8.63921e-07
    cook@nb19          max diff = 0.00001   flux at max diff = 7056.66150   frac diff = 2.03292e-09
    spirou@maestria    max diff = -0.08375   flux at max diff = 96940.69967   frac diff = -8.63884e-07
    newworlds          max diff = 0.00000   flux at max diff = 7056.66149   frac diff = 1.47189e-10
    lam                max diff = -0.08375   flux at max diff = 96940.69967   frac diff = -8.63921e-07
    cfht               max diff = 0.33662   flux at max diff = 60994.95420   frac diff = 5.51890e-06

Order 9
    spirou@rali        max diff = 0.00000   flux at max diff = 4635.57788   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.10178   flux at max diff = 6040.13749   frac diff = -1.68499e-05
    cook@nb19          max diff = -0.03781   flux at max diff = 4635.54006   frac diff = -8.15678e-06
    spirou@maestria    max diff = -0.11703   flux at max diff = 5462.86340   frac diff = -2.14232e-05
    newworlds          max diff = -0.00013   flux at max diff = 4635.57775   frac diff = -2.69658e-08
    lam                max diff = -0.10178   flux at max diff = 6040.13749   frac diff = -1.68499e-05
    cfht               max diff = -0.11179   flux at max diff = 70434.45850   frac diff = -1.58719e-06

Order 10
    spirou@rali        max diff = 0.00000   flux at max diff = 6499.37290   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00639   flux at max diff = 94274.84079   frac diff = -6.77564e-08
    cook@nb19          max diff = 0.00002   flux at max diff = 6499.37291   frac diff = 2.82584e-09
    spirou@maestria    max diff = -0.00639   flux at max diff = 94274.84079   frac diff = -6.77430e-08
    newworlds          max diff = 0.00002   flux at max diff = 6499.37292   frac diff = 2.93785e-09
    lam                max diff = -0.00639   flux at max diff = 94274.84079   frac diff = -6.77564e-08
    cfht               max diff = -0.58383   flux at max diff = 6498.78907   frac diff = -8.98361e-05

Order 11
    spirou@rali        max diff = 0.00000   flux at max diff = 7838.82832   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.14710   flux at max diff = 101483.20984   frac diff = -1.44947e-06
    cook@nb19          max diff = 0.00001   flux at max diff = 7838.82832   frac diff = 8.61213e-10
    spirou@maestria    max diff = -0.14710   flux at max diff = 101483.20984   frac diff = -1.44949e-06
    newworlds          max diff = 0.00000   flux at max diff = 7838.82832   frac diff = 2.64414e-10
    lam                max diff = -0.14710   flux at max diff = 101483.20984   frac diff = -1.44947e-06
    cfht               max diff = -0.07056   flux at max diff = 84712.63272   frac diff = -8.32955e-07

Order 12
    spirou@rali        max diff = 0.00000   flux at max diff = 8527.86520   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.12674   flux at max diff = 19824.18616   frac diff = -6.39317e-06
    cook@nb19          max diff = -0.00000   flux at max diff = 30612.14103   frac diff = -1.40574e-11
    spirou@maestria    max diff = -0.12673   flux at max diff = 19824.18617   frac diff = -6.39294e-06
    newworlds          max diff = 0.00001   flux at max diff = 8527.86522   frac diff = 1.65340e-09
    lam                max diff = -0.12674   flux at max diff = 19824.18616   frac diff = -6.39317e-06
    cfht               max diff = 0.03807   flux at max diff = 100749.62939   frac diff = 3.77878e-07

Order 13
    spirou@rali        max diff = 0.00000   flux at max diff = 9072.41103   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.10311   flux at max diff = 25911.41112   frac diff = 3.97925e-06
    cook@nb19          max diff = 0.00001   flux at max diff = 9072.41105   frac diff = 1.47609e-09
    spirou@maestria    max diff = 0.10311   flux at max diff = 25911.41111   frac diff = 3.97919e-06
    newworlds          max diff = 0.00001   flux at max diff = 9072.41104   frac diff = 1.13195e-09
    lam                max diff = 0.10311   flux at max diff = 25911.41112   frac diff = 3.97925e-06
    cfht               max diff = 0.12406   flux at max diff = 109882.60216   frac diff = 1.12899e-06

Order 14
    spirou@rali        max diff = 0.00000   flux at max diff = 14973.75823   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.24444   flux at max diff = 33495.09500   frac diff = -7.29780e-06
    cook@nb19          max diff = 0.00054   flux at max diff = 14973.75877   frac diff = 3.61642e-08
    spirou@maestria    max diff = -0.24444   flux at max diff = 33689.05210   frac diff = -7.25571e-06
    newworlds          max diff = -0.00001   flux at max diff = 67734.94284   frac diff = -1.03861e-10
    lam                max diff = -0.24444   flux at max diff = 33495.09500   frac diff = -7.29780e-06
    cfht               max diff = 0.16201   flux at max diff = 120726.29371   frac diff = 1.34195e-06

Order 15
    spirou@rali        max diff = 0.00000   flux at max diff = 23006.04937   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.50745   flux at max diff = 36072.69968   frac diff = -1.40675e-05
    cook@nb19          max diff = 0.00004   flux at max diff = 14677.40306   frac diff = 2.99677e-09
    spirou@maestria    max diff = -0.50748   flux at max diff = 36072.69965   frac diff = -1.40683e-05
    newworlds          max diff = 0.00000   flux at max diff = 14677.40301   frac diff = 1.07573e-10
    lam                max diff = -0.50745   flux at max diff = 36072.69968   frac diff = -1.40675e-05
    cfht               max diff = 0.00737   flux at max diff = 145893.93635   frac diff = 5.05455e-08

Order 16
    spirou@rali        max diff = 0.00000   flux at max diff = 14482.49930   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.40978   flux at max diff = 152993.87375   frac diff = 2.67840e-06
    cook@nb19          max diff = -0.00005   flux at max diff = 14482.49925   frac diff = -3.43929e-09
    spirou@maestria    max diff = 0.40978   flux at max diff = 152993.87375   frac diff = 2.67840e-06
    newworlds          max diff = -0.00006   flux at max diff = 14482.49924   frac diff = -3.97429e-09
    lam                max diff = 0.40978   flux at max diff = 152993.87375   frac diff = 2.67840e-06
    cfht               max diff = -0.00189   flux at max diff = 143531.32518   frac diff = -1.31565e-08

Order 17
    spirou@rali        max diff = 0.00000   flux at max diff = 27956.45606   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.07941   flux at max diff = 55873.13987   frac diff = -1.42124e-06
    cook@nb19          max diff = -0.00029   flux at max diff = 27956.45577   frac diff = -1.02794e-08
    spirou@maestria    max diff = -0.07956   flux at max diff = 55506.38202   frac diff = -1.43338e-06
    newworlds          max diff = -0.00072   flux at max diff = 27956.45534   frac diff = -2.58304e-08
    lam                max diff = -0.07941   flux at max diff = 55873.13987   frac diff = -1.42124e-06
    cfht               max diff = 0.01548   flux at max diff = 146647.65932   frac diff = 1.05561e-07

Order 18
    spirou@rali        max diff = 0.00000   flux at max diff = 21729.20836   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.01798   flux at max diff = 110957.20939   frac diff = 1.62033e-07
    cook@nb19          max diff = -0.00004   flux at max diff = 21729.20833   frac diff = -1.61366e-09
    spirou@maestria    max diff = 0.01797   flux at max diff = 110957.20939   frac diff = 1.61995e-07
    newworlds          max diff = -0.00004   flux at max diff = 21729.20832   frac diff = -1.85866e-09
    lam                max diff = 0.01798   flux at max diff = 110957.20939   frac diff = 1.62033e-07
    cfht               max diff = 0.00531   flux at max diff = 167005.71287   frac diff = 3.17933e-08

Order 19
    spirou@rali        max diff = 0.00000   flux at max diff = 22491.93678   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.03127   flux at max diff = 168549.13593   frac diff = 1.85514e-07
    cook@nb19          max diff = 0.00017   flux at max diff = 22491.93695   frac diff = 7.49599e-09
    spirou@maestria    max diff = 0.03126   flux at max diff = 168697.40087   frac diff = 1.85311e-07
    newworlds          max diff = 0.00007   flux at max diff = 22491.93685   frac diff = 2.98655e-09
    lam                max diff = 0.03127   flux at max diff = 168549.13593   frac diff = 1.85514e-07
    cfht               max diff = 0.00119   flux at max diff = 158167.19871   frac diff = 7.50592e-09

Order 20
    spirou@rali        max diff = 0.00000   flux at max diff = 23363.37777   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.01408   flux at max diff = 132726.97648   frac diff = -1.06083e-07
    cook@nb19          max diff = 0.00007   flux at max diff = 23363.37784   frac diff = 2.99039e-09
    spirou@maestria    max diff = -0.01551   flux at max diff = 128721.08663   frac diff = -1.20530e-07
    newworlds          max diff = 0.00283   flux at max diff = 23363.38060   frac diff = 1.20976e-07
    lam                max diff = -0.01408   flux at max diff = 132726.97648   frac diff = -1.06083e-07
    cfht               max diff = 0.00221   flux at max diff = 66303.95392   frac diff = 3.33221e-08

Order 21
    spirou@rali        max diff = 0.00000   flux at max diff = 27848.80792   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.01697   flux at max diff = 243797.85739   frac diff = 6.96208e-08
    cook@nb19          max diff = 0.02167   flux at max diff = 247389.54596   frac diff = 8.76029e-08
    spirou@maestria    max diff = 0.06272   flux at max diff = 248643.55597   frac diff = 2.52231e-07
    newworlds          max diff = 0.02044   flux at max diff = 247698.42131   frac diff = 8.25372e-08
    lam                max diff = 0.01697   flux at max diff = 243797.85739   frac diff = 6.96208e-08
    cfht               max diff = 0.01047   flux at max diff = 248700.37672   frac diff = 4.21116e-08

Order 22
    spirou@rali        max diff = 0.00000   flux at max diff = 28478.56228   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00267   flux at max diff = 261295.14066   frac diff = 1.02253e-08
    cook@nb19          max diff = 0.00359   flux at max diff = 266050.03203   frac diff = 1.34857e-08
    spirou@maestria    max diff = 0.00157   flux at max diff = 63195.38243   frac diff = 2.47852e-08
    newworlds          max diff = 0.00260   flux at max diff = 266057.19205   frac diff = 9.75762e-09
    lam                max diff = 0.00267   flux at max diff = 261295.14066   frac diff = 1.02253e-08
    cfht               max diff = 0.00309   flux at max diff = 258894.99697   frac diff = 1.19534e-08

Order 23
    spirou@rali        max diff = 0.00000   flux at max diff = 32257.30590   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00688   flux at max diff = 197623.26738   frac diff = 3.48060e-08
    cook@nb19          max diff = 0.00045   flux at max diff = 33976.99568   frac diff = 1.31993e-08
    spirou@maestria    max diff = 0.00688   flux at max diff = 198161.63628   frac diff = 3.47413e-08
    newworlds          max diff = 0.00048   flux at max diff = 33976.99572   frac diff = 1.42107e-08
    lam                max diff = 0.00688   flux at max diff = 197623.26738   frac diff = 3.48060e-08
    cfht               max diff = 0.00047   flux at max diff = 33976.99570   frac diff = 1.37621e-08

Order 24
    spirou@rali        max diff = 0.00000   flux at max diff = 20326.24950   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00668   flux at max diff = 255452.84691   frac diff = -2.61454e-08
    cook@nb19          max diff = 0.00200   flux at max diff = 20326.25151   frac diff = 9.85179e-08
    spirou@maestria    max diff = -0.00661   flux at max diff = 239895.50170   frac diff = -2.75565e-08
    newworlds          max diff = 0.00511   flux at max diff = 20326.25461   frac diff = 2.51307e-07
    lam                max diff = -0.00668   flux at max diff = 255452.84691   frac diff = -2.61454e-08
    cfht               max diff = -0.00290   flux at max diff = 20326.24660   frac diff = -1.42858e-07

Order 25
    spirou@rali        max diff = 0.00000   flux at max diff = 31820.95019   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00005   flux at max diff = 43564.56824   frac diff = 1.11990e-09
    cook@nb19          max diff = -0.06215   flux at max diff = 43564.50603   frac diff = -1.42671e-06
    spirou@maestria    max diff = 0.00029   flux at max diff = 43564.56848   frac diff = 6.71193e-09
    newworlds          max diff = -0.00023   flux at max diff = 43564.56796   frac diff = -5.33868e-09
    lam                max diff = 0.00005   flux at max diff = 43564.56824   frac diff = 1.11990e-09
    cfht               max diff = 0.00076   flux at max diff = 43564.56895   frac diff = 1.75462e-08

Order 26
    spirou@rali        max diff = 0.00000   flux at max diff = 33346.70291   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00277   flux at max diff = 33346.70568   frac diff = 8.29710e-08
    cook@nb19          max diff = -0.01254   flux at max diff = 33346.69037   frac diff = -3.76005e-07
    spirou@maestria    max diff = -0.00964   flux at max diff = 33346.69327   frac diff = -2.88985e-07
    newworlds          max diff = -0.00880   flux at max diff = 33346.69410   frac diff = -2.64011e-07
    lam                max diff = 0.00277   flux at max diff = 33346.70568   frac diff = 8.29710e-08
    cfht               max diff = -0.03676   flux at max diff = 33346.66615   frac diff = -1.10246e-06

Order 27
    spirou@rali        max diff = 0.00000   flux at max diff = 55404.60929   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00070   flux at max diff = 54058.75852   frac diff = 1.29551e-08
    cook@nb19          max diff = -0.09388   flux at max diff = 54058.66394   frac diff = -1.73663e-06
    spirou@maestria    max diff = -0.00239   flux at max diff = 54058.75543   frac diff = -4.42776e-08
    newworlds          max diff = -0.02497   flux at max diff = 54058.73285   frac diff = -4.61931e-07
    lam                max diff = 0.00070   flux at max diff = 54058.75852   frac diff = 1.29551e-08
    cfht               max diff = -0.00068   flux at max diff = 54058.75714   frac diff = -1.25634e-08

Order 28
    spirou@rali        max diff = 0.00000   flux at max diff = 34907.44640   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00005   flux at max diff = 34907.44634   frac diff = -1.56874e-09
    cook@nb19          max diff = -0.00005   flux at max diff = 34907.44635   frac diff = -1.53882e-09
    spirou@maestria    max diff = 0.00002   flux at max diff = 34907.44642   frac diff = 6.68854e-10
    newworlds          max diff = -0.00005   flux at max diff = 34907.44635   frac diff = -1.37513e-09
    lam                max diff = -0.00005   flux at max diff = 34907.44634   frac diff = -1.56874e-09
    cfht               max diff = -0.00003   flux at max diff = 34907.44637   frac diff = -7.54134e-10

Order 29
    spirou@rali        max diff = 0.00000   flux at max diff = 41364.22755   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00660   flux at max diff = 41364.23415   frac diff = 1.59649e-07
    cook@nb19          max diff = -0.00284   flux at max diff = 41364.22470   frac diff = -6.87773e-08
    spirou@maestria    max diff = -0.00212   flux at max diff = 41364.22543   frac diff = -5.12999e-08
    newworlds          max diff = 0.00210   flux at max diff = 41364.22965   frac diff = 5.08875e-08
    lam                max diff = 0.00660   flux at max diff = 41364.23415   frac diff = 1.59649e-07
    cfht               max diff = -0.00186   flux at max diff = 41364.22569   frac diff = -4.49088e-08

Order 30
    spirou@rali        max diff = 0.00000   flux at max diff = 51849.54674   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00577   flux at max diff = 51849.55251   frac diff = 1.11250e-07
    cook@nb19          max diff = -0.00248   flux at max diff = 51849.54425   frac diff = -4.79248e-08
    spirou@maestria    max diff = -0.00250   flux at max diff = 51849.54424   frac diff = -4.81603e-08
    newworlds          max diff = -0.00823   flux at max diff = 51849.53851   frac diff = -1.58656e-07
    lam                max diff = 0.00577   flux at max diff = 51849.55251   frac diff = 1.11250e-07
    cfht               max diff = 0.00941   flux at max diff = 51849.55614   frac diff = 1.81394e-07

Order 31
    spirou@rali        max diff = 0.00000   flux at max diff = 74039.36904   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.05415   flux at max diff = 92643.70555   frac diff = 5.84516e-07
    cook@nb19          max diff = 0.05670   flux at max diff = 92643.70809   frac diff = 6.11987e-07
    spirou@maestria    max diff = 0.01313   flux at max diff = 92643.66453   frac diff = 1.41760e-07
    newworlds          max diff = 0.05660   flux at max diff = 92643.70799   frac diff = 6.10937e-07
    lam                max diff = 0.05415   flux at max diff = 92643.70555   frac diff = 5.84516e-07
    cfht               max diff = 0.02663   flux at max diff = 92643.67803   frac diff = 2.87482e-07

Order 32
    spirou@rali        max diff = 0.00000   flux at max diff = 83761.12800   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00003   flux at max diff = 83761.12797   frac diff = -3.82031e-10
    cook@nb19          max diff = 0.00004   flux at max diff = 83761.12804   frac diff = 4.75592e-10
    spirou@maestria    max diff = 0.00024   flux at max diff = 83761.12824   frac diff = 2.89904e-09
    newworlds          max diff = 0.00012   flux at max diff = 83761.12812   frac diff = 1.44041e-09
    lam                max diff = -0.00003   flux at max diff = 83761.12797   frac diff = -3.82031e-10
    cfht               max diff = 0.00051   flux at max diff = 83761.12851   frac diff = 6.07643e-09

Order 33
    spirou@rali        max diff = 0.00000   flux at max diff = 99897.56242   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00742   flux at max diff = 99897.55501   frac diff = -7.42373e-08
    cook@nb19          max diff = 0.01642   flux at max diff = 99897.57885   frac diff = 1.64397e-07
    spirou@maestria    max diff = 0.01853   flux at max diff = 99897.58096   frac diff = 1.85521e-07
    newworlds          max diff = 0.01756   flux at max diff = 99897.57998   frac diff = 1.75759e-07
    lam                max diff = -0.00742   flux at max diff = 99897.55501   frac diff = -7.42373e-08
    cfht               max diff = 0.03323   flux at max diff = 99897.59565   frac diff = 3.32659e-07

Order 34
    spirou@rali        max diff = 0.00000   flux at max diff = 120115.28408   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.03914   flux at max diff = 117104.67619   frac diff = 3.34227e-07
    cook@nb19          max diff = -0.00694   flux at max diff = 117104.63011   frac diff = -5.93002e-08
    spirou@maestria    max diff = 0.02171   flux at max diff = 117104.65876   frac diff = 1.85418e-07
    newworlds          max diff = 0.02820   flux at max diff = 117104.66525   frac diff = 2.40783e-07
    lam                max diff = 0.03914   flux at max diff = 117104.67619   frac diff = 3.34227e-07
    cfht               max diff = 0.02281   flux at max diff = 117104.65986   frac diff = 1.94825e-07

Order 35
    spirou@rali        max diff = 0.00000   flux at max diff = 135711.34749   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.08138   flux at max diff = 135711.42887   frac diff = 5.99672e-07
    cook@nb19          max diff = 0.11247   flux at max diff = 129518.85406   frac diff = 8.68347e-07
    spirou@maestria    max diff = 0.07935   flux at max diff = 135711.42684   frac diff = 5.84686e-07
    newworlds          max diff = 0.08222   flux at max diff = 135711.42971   frac diff = 6.05840e-07
    lam                max diff = 0.08138   flux at max diff = 135711.42887   frac diff = 5.99672e-07
    cfht               max diff = 0.08361   flux at max diff = 135711.43110   frac diff = 6.16067e-07

Order 36
    spirou@rali        max diff = 0.00000   flux at max diff = 150001.94742   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.01342   flux at max diff = 525560.10515   frac diff = -2.55367e-08
    cook@nb19          max diff = -0.01839   flux at max diff = 524344.84068   frac diff = -3.50761e-08
    spirou@maestria    max diff = -0.00175   flux at max diff = 145280.17246   frac diff = -1.20363e-08
    newworlds          max diff = -0.01793   flux at max diff = 525141.18465   frac diff = -3.41467e-08
    lam                max diff = -0.01342   flux at max diff = 525560.10515   frac diff = -2.55367e-08
    cfht               max diff = -0.02253   flux at max diff = 145280.15167   frac diff = -1.55099e-07

Order 37
    spirou@rali        max diff = 0.00000   flux at max diff = 182215.94921   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00059   flux at max diff = 149740.33066   frac diff = -3.95274e-09
    cook@nb19          max diff = -0.00059   flux at max diff = 149740.33066   frac diff = -3.96163e-09
    spirou@maestria    max diff = -0.00063   flux at max diff = 149740.33063   frac diff = -4.18113e-09
    newworlds          max diff = -0.00009   flux at max diff = 521404.64512   frac diff = -1.81138e-10
    lam                max diff = -0.00059   flux at max diff = 149740.33066   frac diff = -3.95274e-09
    cfht               max diff = -0.00006   flux at max diff = 149740.33119   frac diff = -4.21160e-10

Order 38
    spirou@rali        max diff = 0.00000   flux at max diff = 194997.30946   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00780   flux at max diff = 156687.03886   frac diff = -4.97935e-08
    cook@nb19          max diff = -0.11404   flux at max diff = 156686.93262   frac diff = -7.27828e-07
    spirou@maestria    max diff = 0.02883   flux at max diff = 156687.07549   frac diff = 1.83998e-07
    newworlds          max diff = 0.10992   flux at max diff = 156687.15658   frac diff = 7.01532e-07
    lam                max diff = -0.00780   flux at max diff = 156687.03886   frac diff = -4.97935e-08
    cfht               max diff = 0.12354   flux at max diff = 156687.17021   frac diff = 7.88471e-07

Order 39
    spirou@rali        max diff = 0.00000   flux at max diff = 217726.83253   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.02744   flux at max diff = 171876.69585   frac diff = 1.59629e-07
    cook@nb19          max diff = 0.01240   flux at max diff = 171876.68082   frac diff = 7.21697e-08
    spirou@maestria    max diff = 0.10513   flux at max diff = 171876.77355   frac diff = 6.11687e-07
    newworlds          max diff = 0.12249   flux at max diff = 171876.79090   frac diff = 7.12661e-07
    lam                max diff = 0.02744   flux at max diff = 171876.69585   frac diff = 1.59629e-07
    cfht               max diff = 0.12006   flux at max diff = 171876.78847   frac diff = 6.98521e-07

Order 40
    spirou@rali        max diff = 0.00000   flux at max diff = 239439.40096   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00254   flux at max diff = 239439.39842   frac diff = -1.06196e-08
    cook@nb19          max diff = 0.13994   flux at max diff = 239439.54090   frac diff = 5.84441e-07
    spirou@maestria    max diff = -0.00309   flux at max diff = 239439.39787   frac diff = -1.29118e-08
    newworlds          max diff = 0.14191   flux at max diff = 239439.54287   frac diff = 5.92659e-07
    lam                max diff = -0.00254   flux at max diff = 239439.39842   frac diff = -1.06196e-08
    cfht               max diff = -0.01402   flux at max diff = 239439.38694   frac diff = -5.85541e-08

Order 41
    spirou@rali        max diff = 0.00000   flux at max diff = 262597.10057   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00335   flux at max diff = 262597.10391   frac diff = 1.27399e-08
    cook@nb19          max diff = 0.00631   flux at max diff = 262597.10687   frac diff = 2.40202e-08
    spirou@maestria    max diff = 0.00540   flux at max diff = 262597.10597   frac diff = 2.05721e-08
    newworlds          max diff = 0.00348   flux at max diff = 262597.10404   frac diff = 1.32466e-08
    lam                max diff = 0.00335   flux at max diff = 262597.10391   frac diff = 1.27399e-08
    cfht               max diff = 0.00478   flux at max diff = 262597.10535   frac diff = 1.82207e-08

Order 42
    spirou@rali        max diff = 0.00000   flux at max diff = 296530.66620   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00721   flux at max diff = 202761.51793   frac diff = -3.55514e-08
    cook@nb19          max diff = -0.00632   flux at max diff = 202761.51882   frac diff = -3.11776e-08
    spirou@maestria    max diff = -0.02511   flux at max diff = 202761.50003   frac diff = -1.23830e-07
    newworlds          max diff = 0.00625   flux at max diff = 202761.53139   frac diff = 3.08306e-08
    lam                max diff = -0.00721   flux at max diff = 202761.51793   frac diff = -3.55514e-08
    cfht               max diff = -0.03054   flux at max diff = 250461.89393   frac diff = -1.21949e-07

Order 43
    spirou@rali        max diff = 0.00000   flux at max diff = 313761.70233   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.02788   flux at max diff = 313761.67446   frac diff = -8.88483e-08
    cook@nb19          max diff = 0.01361   flux at max diff = 313761.71595   frac diff = 4.33807e-08
    spirou@maestria    max diff = 0.00346   flux at max diff = 313761.70579   frac diff = 1.10213e-08
    newworlds          max diff = 0.00299   flux at max diff = 313761.70533   frac diff = 9.53381e-09
    lam                max diff = -0.02788   flux at max diff = 313761.67446   frac diff = -8.88483e-08
    cfht               max diff = 0.00353   flux at max diff = 313761.70587   frac diff = 1.12542e-08

Order 44
    spirou@rali        max diff = 0.00000   flux at max diff = 306492.58635   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00299   flux at max diff = 306492.58335   frac diff = -9.77176e-09
    cook@nb19          max diff = 0.01946   flux at max diff = 306492.60581   frac diff = 6.34965e-08
    spirou@maestria    max diff = -0.04033   flux at max diff = 306492.54601   frac diff = -1.31592e-07
    newworlds          max diff = -0.03067   flux at max diff = 306492.55567   frac diff = -1.00081e-07
    lam                max diff = -0.00299   flux at max diff = 306492.58335   frac diff = -9.77176e-09
    cfht               max diff = -0.01535   flux at max diff = 306492.57099   frac diff = -5.00889e-08

Order 45
    spirou@rali        max diff = 0.00000   flux at max diff = 248841.59537   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.00558   flux at max diff = 136304.72323   frac diff = 4.09074e-08
    cook@nb19          max diff = 0.01068   flux at max diff = 136304.72834   frac diff = 7.83710e-08
    spirou@maestria    max diff = 0.04651   flux at max diff = 136304.76416   frac diff = 3.41218e-07
    newworlds          max diff = -0.08019   flux at max diff = 136304.63746   frac diff = -5.88304e-07
    lam                max diff = 0.00558   flux at max diff = 136304.72323   frac diff = 4.09074e-08
    cfht               max diff = -0.06888   flux at max diff = 136304.64877   frac diff = -5.05338e-07

Order 46
    spirou@rali        max diff = 0.00000   flux at max diff = 223258.30352   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.07028   flux at max diff = 122143.02927   frac diff = 5.75421e-07
    cook@nb19          max diff = -0.00032   flux at max diff = 223258.30319   frac diff = -1.44414e-09
    spirou@maestria    max diff = -0.19953   flux at max diff = 223258.10399   frac diff = -8.93716e-07
    newworlds          max diff = 0.07828   flux at max diff = 122143.03726   frac diff = 6.40886e-07
    lam                max diff = 0.07028   flux at max diff = 122143.02927   frac diff = 5.75421e-07
    cfht               max diff = 0.07089   flux at max diff = 122143.02987   frac diff = 5.80394e-07

Order 47
    spirou@rali        max diff = 0.00000   flux at max diff = 219828.32482   frac diff = 0.00000e+00
    cook@jupiter       max diff = -0.00066   flux at max diff = 83321.72059   frac diff = -7.89373e-09
    cook@nb19          max diff = -0.00044   flux at max diff = 83321.72080   frac diff = -5.31298e-09
    spirou@maestria    max diff = -0.00088   flux at max diff = 83321.72037   frac diff = -1.05135e-08
    newworlds          max diff = -0.00096   flux at max diff = 83321.72029   frac diff = -1.14870e-08
    lam                max diff = -0.00066   flux at max diff = 83321.72059   frac diff = -7.89373e-09
    cfht               max diff = -0.00061   flux at max diff = 83321.72063   frac diff = -7.35649e-09

Order 48
    spirou@rali        max diff = 0.00000   flux at max diff = 142193.15071   frac diff = 0.00000e+00
    cook@jupiter       max diff = 0.01797   flux at max diff = 166559.32678   frac diff = 1.07912e-07
    cook@nb19          max diff = -0.14708   flux at max diff = 142193.00363   frac diff = -1.03440e-06
    spirou@maestria    max diff = 0.06023   flux at max diff = 142193.21094   frac diff = 4.23602e-07
    newworlds          max diff = -0.14398   flux at max diff = 142193.00673   frac diff = -1.01260e-06
    lam                max diff = 0.01797   flux at max diff = 166559.32678   frac diff = 1.07912e-07
    cfht               max diff = 0.10799   flux at max diff = 142193.25870   frac diff = 7.59476e-07
njcuk9999 commented 1 year ago

So yer most blazes are at numerical levels (fractionally ~10^-7) with the largest deviation being fractional = 10^-5 on order 10.

njcuk9999 commented 11 months ago

This is with v0.7.288 with the four machines in Montreal:

image

rms of difference spirou@rali-cook@jupiter = 0.15466742511421885 m/s
rms of difference spirou@rali-cook@nb19 = 0.016303989383939683 m/s
rms of difference spirou@rali-spirou@maestria = 0.044794374568119605 m/s

If you can just drop your GL699_GL699 files in here: https://drive.google.com/drive/folders/1XpgLS_mD0-vZXMFIJCblZPoKBsC0xoC1?usp=sharing I'll add to the comparison

@clairem789 turns out my code needs the .fits files too (sorry)

For everyone else: I'll need the .rdb and .fits files in the lblrdb directory (or just everything in that directory) for GL699_GL699

If this shows larger changes we'll need someone to look at the inputs to LBL (the tcorr + blaze) to compare how different things are before going into LBL.

larnoldgithub commented 11 months ago

@njcuk9999 I have uploaded my lbl files to your google drive. Just to let you know.

larnoldgithub commented 11 months ago

Comparison between CFHT and NW minidataset .288 @njcuk9999 @clairem789 night 2020-05-14 Gl699 *o_pp.fits: difference = exactly 0 A difference is visible in blaze, order 10. Also in tcorr. Screenshot 2023-10-03 at 22 45 41 Screenshot 2023-10-03 at 22 47 23 Screenshot 2023-10-03 at 22 48 34 Screenshot 2023-10-03 at 22 49 18

njcuk9999 commented 11 months ago

This isn't really a good way to plot this. You need to make the difference fractional or relative to the flux in one of the images.

Instead of a direct difference you need difference/mean value of the two images at each pixel... you'll see its tiny (at the numerical accuracy level). The values of the blaze are huge compared to a value of "10".