search

njcuk9999 / apero-drs

A PipelinE to Reduce Observations - The DRS for SPIRou (CFHT)
MIT License
12 stars 0 forks source link

Wrong labelling of atmospheric molecules in tapas_all_sp.fits (fields of the fits table) #742

Closed larnoldgithub closed 5 months ago

larnoldgithub commented 7 months ago

For the record, the labels for each field are incorrect, but for water. Water and all other 'dry' species are handled separately in APERO so it's not a big deal if it's named for example N2O while it's CO2...

FITS file: tapas_all_sp.fits

Extension No: 1 FITS Binary Table: Size 64 by 374499 Field Name Unit Frmt Null Comment 1 wavelength D
2 trans_h2o D
3 trans_o3 D
4 trans_n2o D
5 trans_o2 D
6 trans_co2 D
7 trans_ch4 D
8 trans_combined D

actually, it should be: Field Name 1 wavelength
2 trans_h2o (white)
3 trans_ch4 (blue)
4 trans_co2 (orange) 5 transno2 (yellow) 6 trans o2 (red) 7 trans_o3 (purple)

tapas-templates

njcuk9999 commented 7 months ago

@eartigau created this file manually I think so it may not be exactly as downloaded. I will let him comment on this. As you say they are all bundled in to dry components so as long as water is correct apero works correctly but we should have the correct labels.

njcuk9999 commented 5 months ago

So I just got @eartigau to confirm, we did have them mislabeled (I thought he might have just rearranged the columns). I'll add these to a few other bug fixes for v0.7.289.

Note that this doesn't affect anything in the apero codes (as you say they all get merged to "dry") it will just affect the fits file itself.