search

njcuk9999 / apero-utils

APERO affiliated utilities and tools
MIT License
3 stars 3 forks source link

New raw and red tests to apero_checks #154

Closed fgenest1 closed 1 year ago

fgenest1 commented 1 year ago

This adds the pixel shift test to red_tests and some general quality checks (saturation and flux) for science and calibration files to raw_checks.

njcuk9999 commented 1 year ago

Actually just a few notes (or at least explanations why I changed a few things).

file is a function in python so you shouldn't use it as a variable name (i.e. when you do or file in files) I've changed file to filename.

Also I try to keep path operations OS independent, hence file.split('/')[-1] isn't a good option os has some nice functionality: os.path.basename(file) would give you the same functionality in an OS system independent way. Also there is os.path.dirname(filename) for the path.

Also try to avoid one character variables.

In general I try to keep lines < 80 characters.