njcuk9999 / apero-utils

APERO affiliated utilities and tools
MIT License
3 stars 3 forks source link

[APERO] Object reject list doesn't work - some objects without pm need to be in ARI #220

Closed njcuk9999 closed 4 months ago

njcuk9999 commented 9 months ago

astrometric database was originally only used for BERV thus objects without proper motion were added to the reject list. Some of these targets are required in ARI (which now uses the astrometric database)

Or need a column in reject list for "bad astrometrics" and make sure ARI does not reject these

njcuk9999 commented 8 months ago

Add a "BAD_ASTROMETRICS" column to object reject list - get ARI to look for objects in reject list if BAD_ASTROMETRICS == 1 then we can put it into ARI.

Or we get all objects on disk and filter out only objects with BAD_ASTROMETRICS == 0 (for ARI) Will have to figure out how to get astrometric properties for those not in astrometric database (or add "Not in astrometric database" to ARI object page)

njcuk9999 commented 4 months ago

Turns out it doesn't filter by rejected objects, it just uses all objects in the main databases.

Objects in the reject list are not in the main database (by definition)

Probably need to add bad proper motion targets to the database - use reject list of targets only when needed (in preprocessing)?

njcuk9999 commented 4 months ago

Added bad proper motion targets to the main database with KEYWORD="NO_PM" - will be filtered out in preprocessing (i.e. use header values) and thus ARI will work.