njcuk9999
commented
1 year ago This all looks good.
I think for now its fine getting the data from cosmos.
By "downloads the geneva data" do you mean it does an rsync? If so do you remove the data afterwards or do we get a pile up of files after this?
Is there an option to run this on nirps-client account and just access the data directly?
If you have lots of time you could add options to have the blaze corrected spectrum
Same for geting the data from DACE but I think eventually we will be running this as part of a suite of tests that produces graphs, so at least the DACE part shouldn't be required.
I haven't seen any code yet but please make sure you have good instructions on how to use the code and comments in the code to explain what you are doing.
LucBazinet
I am pretty much done with this task. I just want to make sure everything is fine before doing a pull request. I made 2 scripts, one for plotting the 1D spectra and one for the 2D spectra.
The 1D spectra script plots the apero extracted spectra (filename ending with _pp_s1d_vA.fits) and telluric corrected spectra (ending with _pp_s1d_v_tcorrA.fits). It also plot the geneva extracted spectra (ending with _S1DA.fits) and skysub spectra (ending with _S1D_SKYSUBA.fits). Here is an example:
The 2D spectra script plots the a user-defined order of an apero extracted spectra (filename ending with _pp_e2dsffA.fits) and telluric corrected spectra (ending with _pp_e2dsff_tcorrA.fits). It also plot the geneva extracted spectra (ending with _S2D_BLAZEA.fits) and telluric corrected spectra (ending with _S2D_BLAZE_TELL_CORRA.fits).
Should I include other spectra in either script (such as the blaze corrected spectra)? Also, right now the scripts downloads the geneva data from /cosmos99/nirps/geneva-data/DRS-3.0.0/reduced/..., should I change this so it gets the data from DACE instead?