search

njdehoog / Spelt

Delightfully simple static site generator written in Swift [NO LONGER MAINTAINED]
MIT License
132 stars 14 forks source link

Update dependencies, update to Swift 4.2 #12

Closed weissazool closed 5 years ago

weissazool commented 5 years ago

There's one awkward thing right now with Stencil that will prevent this from building. Basically, since it's just a git submodule, there is no Stencil module to namespace or import, so the usage of Stencil.normalize(value) breaks.

Installing it via SPM or Carthage instead of git submodules should solve this issue. I'll probably add that as an additional commit within this PR but wanted to initially submit this as a heads up.

weissazool commented 5 years ago

Based on #3 it seems like the issue has already been raised.

weissazool commented 5 years ago

In trying to move Stencil to Carthage, some interfaces to the Context struct become unavailable. I don't understand the project well enough yet to work around it properly.

njdehoog commented 5 years ago

Hi @weissazool, thanks for the PR! I'm sorry to say this project is no longer maintained, so you're probably best off forking the project and starting from there.

Regarding your issue with Stencil. If I remember correctly, I created a fork of the main Stencil repo, because there were some bugs I needed to fix, or features added, for this project to work, and it was hard to get those changes applied in the main repo in the timeframe that I wanted. It could very well be that those bugs no longer exist or those features have been added in Stencil, which would make it possible to switch back. It might require some refactoring though.

weissazool commented 5 years ago

No problem - I figured this might not be maintained but thought I'd send the PR regardless. Appreciate the advice re: Stencil, cheers!