search

njelich / LinkOff

Cleans the LinkedIn feed based on keywords and filters.
MIT License
168 stars 19 forks source link

'supports this' reactions are not filtered when 'Hide with other reactions' is selected #53

Closed sofyk closed 1 week ago

sofyk commented 10 months ago

Describe the bug I have 'Hide with other reactions' selected but I still see posted with 'supports this' reactions in my feed.

To Reproduce Steps to reproduce the behavior:

  1. Enable 'Hide with other reactions'
  2. go to Linkedin feed
  3. observe 'supports this' reactions are not being hidden

Expected behavior when 'Hide with other reactions' is enabled, posts with 'supports this' reactions should be filtered as well.

Screenshots image

Environment (please complete the following information):

Additional context Add any other context about the problem here.

njelich commented 10 months ago

I am extremely busy these days, but these cases are handled here:

https://github.com/njelich/LinkOff/blob/104c15cf59c56bba67e64283db95690f196ea61c/content/content.js#L266

The detection is based on specific strings appearing in posts.

sofyk commented 10 months ago

understandable! thanks for the info

valdoryu commented 1 week ago

I can't reproduce this issue, do you still experience it @sofyk ?

sofyk commented 1 week ago

not sure haven't tried it in a while. probably fixed.