PR for apply https://github.com/njh/EtherCard/issues/384 possible fix - Githubissues

njh / EtherCard

EtherCard is an IPv4 driver for the ENC28J60 chip, compatible with Arduino IDE

https://www.aelius.com/njh/ethercard/

GNU General Public License v2.0

1.03k stars 455 forks source link

PR for apply https://github.com/njh/EtherCard/issues/384 possible fix #385

Open mrv96 opened 4 years ago

nuno-silva commented 4 years ago

Looks good, but I would also update the JeeUdp example sketch here https://github.com/njh/EtherCard/blob/420dd84ca4b5b4187896cf4aa23cd8ac66ae2cab/examples/JeeUdp/JeeUdp.ino#L252 to get rid of the invalid conversion warning: https://travis-ci.com/github/njh/EtherCard/jobs/367604836#L665-L672

udpClientSendOnly.ino is also affected, as it uses char*: https://github.com/njh/EtherCard/blob/420dd84ca4b5b4187896cf4aa23cd8ac66ae2cab/examples/udpClientSendOnly/udpClientSendOnly.ino#L31-L37

mrv96 commented 1 year ago

Squashed commits and updated examples