search

njh / mqtt-sn-tools

Command line tools written in C for the MQTT-SN (MQTT for Sensor Networks) protocol
MIT License
195 stars 84 forks source link

Forwarder Encapsulation support. #6

Closed MichalFoksa closed 9 years ago

MichalFoksa commented 9 years ago
  1. Added support of Forwarder Encapsulation. Mqtt-SN packets are encapsulated according to MQTT-SN Protocol Specification v1.2, chapter 5.5.
  2. All log messages to stderr prefixed with current time, e.g: 17:21:10 mqtt-sn-tools-8164 sending CONNECT packet... 17:21:10 Waiting for a packet... 17:21:10 Received 3 bytes. Type=CONNACK on Socket: 3 17:21:10 CONNACK return code: 0x00
  3. Added ignore of exe files into .gitignore.
njh commented 9 years ago

Would it be possible to split 1, 2 and 3 into separate PRs please?

I am not sure about the way you are generating/displaying timestamps using CUR_TIME. I think it would be better to have a log() method.

For 3, it would be better to just add *.exe to .gitignore

MichalFoksa commented 9 years ago

Nicholas,

I do not know how to create 3 separate pull requests, I think it is even more complicated when I fix "white space problems" cause I will create additional commits with all, already committed functionalities.