reserved identifier violation

njh / twolame

MPEG Audio Layer 2 (MP2) encoder

http://www.twolame.org/

GNU Lesser General Public License v2.1

59 stars 34 forks source link

reserved identifier violation #15

Closed elfring closed 12 years ago

elfring commented 12 years ago

I suggest to try the search pattern "\<(?:(?:(.*))|([A-Z]+))" on source files. Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:

This does not fit to the expected naming conventions of the C language standard. I recommend to adjust your selection for unique names.

njh commented 12 years ago

Are you on a one-man crusade to fix and educate the world?

Will get this fixed.

elfring commented 12 years ago

Maybe ... - I have got a desire to improve free software in various ways. ;-)

njh commented 12 years ago

Fixed in 3a78d2753a8c83db14db07d6d6ff3cc980d6261a.

Your regex didn't work for me. Any others needing fixed?

elfring commented 12 years ago

I do not find any more update candidates for the reported pattern in your source files after this change. Thanks for your include guard adjustments.