search

njh / twolame

MPEG Audio Layer 2 (MP2) encoder
http://www.twolame.org/
GNU Lesser General Public License v2.1
59 stars 34 forks source link

Obsolete keyword #63

Closed eblanca closed 6 years ago

eblanca commented 6 years ago

I see the code still uses some "register" keyword for a bunch of variables. This used to be added as a suggestion to the compiler, which would use a cpu register instead of a memory location and get a faster access to a given variable, but nowadays this choice is better done by modern compilers, AFAIK. What do you think about removing them all ?

njh commented 6 years ago

Are you seeing warnings in your compiler? Is there any harm in leaving them there?

My only concern is if people using older compilers still need it.

eblanca commented 6 years ago

Well, I currently have no issues here about this keyword, so in case of people still using old compilers (I didn't think of those users) it may well stay there.