search

njh / twolame

MPEG Audio Layer 2 (MP2) encoder
http://www.twolame.org/
GNU Lesser General Public License v2.1
59 stars 34 forks source link

Sndfile only #71

Closed eblanca closed 6 years ago

eblanca commented 7 years ago

This PR removes audioin_raw.c and uses audioin_sndfile.c for any input file, even raw. Works also in cases of wrong endian samples (little<->big), just run with "-x".

eblanca commented 7 years ago

I see this solution does not handle the case of input through stdin, so I'll do some further tests.

eblanca commented 7 years ago

I think it is fixed now.

njh commented 7 years ago

Thanks, I will take a look.

There should be a test for reading from STDIN.

One of the reasons for having audioin_raw.c, was so that it was possible to use twolame on systems that don't have/support libsndfile. I am not sure how many people actually use this feature though, as libsndfile is very widely supported.

eblanca commented 7 years ago

it was possible to use twolame on systems that don't have/support libsndfile

The configure script currently does not build the frontend when libsndfile is not detected.

njh commented 6 years ago

Merge conflicts resolved: https://github.com/njh/twolame/tree/sndfile_only

njh commented 6 years ago

Build passing: https://travis-ci.org/njh/twolame/builds/309061051

njh commented 6 years ago

This is now merged into master.

As there is now only a single input method, I removed the audioin shim and audioin_sndfile.c.