Better fix for not allowed bitrate

njh / twolame

MPEG Audio Layer 2 (MP2) encoder

http://www.twolame.org/

GNU Lesser General Public License v2.1

59 stars 34 forks source link

Better fix for not allowed bitrate #77

Closed eblanca closed 6 years ago

eblanca commented 6 years ago

This new PR includes the old fix for not allowed bitrate (which caused a crash when encoding mpeg2 content) and better protection for max bitrate value in vbr encodings. This used to pass before only because twolame_get_bitrate_index returned zero, which is wrong result but allowed the check to pass.

njh commented 6 years ago

Travis failed due to the lack of NEWS file - I am working on fixing that bug now...

njh commented 6 years ago

Added test for this fix in d218b204aebd78b0ef1e39589a06f2fc9c655941