search

njh / twolame

MPEG Audio Layer 2 (MP2) encoder
http://www.twolame.org/
GNU Lesser General Public License v2.1
59 stars 34 forks source link

Fix static linking with libmagic #81

Closed ffontaine closed 5 years ago

ffontaine commented 5 years ago

libmagic (from file package) already provides the buffer_init function so to avoid a build failure for applications wanting to statically link with twolame and libmagic (for example sox), rename buffer_init into bitbuffer_init (also rename buffer_deinit into bitbuffer_deinit and buffer_sstell into bitbuffer_sstell for consistency)

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

njh commented 5 years ago

Thanks Fabrice. Hm, all non-static methods should be prefixed by twolame_ I think

njh commented 5 years ago

Hopefully I have fixed this by renaming all the global symbols in 2cca8d26da8aee0c177c8726c2353c62cd4eb492

Can you check that it works for you?

Thanks,

nick.