add -no-undefined for compilation on Windows

njh / twolame

MPEG Audio Layer 2 (MP2) encoder

http://www.twolame.org/

GNU Lesser General Public License v2.1

59 stars 34 forks source link

Closed vtorri closed 5 years ago

vtorri commented 5 years ago

this flags as no side effect on linux as anyway all the symbols should be defined

vtorri commented 5 years ago

do you think you could test this pull request before the next release ?

njh commented 5 years ago

Build with the new -no-undefined option still succeeding with:

Hopefully it is now working for you on Windows...

vtorri commented 5 years ago

plenty of

warning: "DLL_EXPORT" redefined

because you wrongly defines DLL_EXPORT in twolame.h, cf #85

njh commented 5 years ago

Should I revert this change until there is a better fix for Windows then?

vtorri commented 5 years ago

no, there is something else to do. -no-undefined is necessary for Windows.

I will create another pull request, so that you can see what is needed, now.