Fix symbols visibility on Windows

njh / twolame

MPEG Audio Layer 2 (MP2) encoder

http://www.twolame.org/

GNU Lesser General Public License v2.1

59 stars 34 forks source link

Fix symbols visibility on Windows #90

Closed vtorri closed 5 years ago

vtorri commented 5 years ago

both static and shared linking have been tested (with the frontend)

vtorri commented 5 years ago

I can give you more details if you want

vtorri commented 5 years ago

you are not convinced by this PR ?

vtorri commented 5 years ago

will you have time to review this PR ?

njh commented 5 years ago

The problem is that I have no way of testing this, or knowing if the Windows build is working correctly. I also have no idea about best practices for Windows.

Would it be possible to add a Windows build to Travis CI?

https://docs.travis-ci.com/user/reference/windows/

vtorri commented 5 years ago

to have a CI for windows, maybe appveyor is better than travis you can also install mingw-w64 cross toolchain and compile it like a unix build

njh commented 5 years ago

Sorry for the delay in getting this merged.

I have made one minor change: 7cf0a8ac456f69e4b9c40e8cdfd6db2f35114876

I renamed TWOLAME_BUILD define to LIBTWOLAME_BUILD. This is to clarify that LIBTWOLAME_BUILD should only be set when building libtwolame and not the twolame frontend binary.

vtorri commented 5 years ago

no problem for me :-) thanks

vtorri commented 5 years ago

i'll check this evening the compilation on Windows.

for appveyor : https://www.appveyor.com/docs/windows-images-software/