search

njlr / thoth-json-codec

Codec support for Thoth.Json
MIT License
7 stars 1 forks source link

migrate to Thoth.Json.Core #6

Open joprice opened 3 months ago

joprice commented 3 months ago

I tried out migrating to Thoth.Json.Core and it seems that Auto is the only missing piece https://github.com/njlr/thoth-json-codec/compare/master...joprice:thoth-json-codec:thoth-core. I changed things in place, but perhaps the code should just be copy pasted into a new folder named something like thoth-json-core-codec?

njlr commented 3 months ago

Hi there :wave:

I have a draft PR for auto support on top of the new Thoth.Json.Core: https://github.com/thoth-org/Thoth.Json/pull/189 That would need to be merged before auto codecs can be implemented for the new Thoth.

My PR moves auto into a new package so that it is possible to use core Thoth without any reflection.

So I think a good approach here would be to have two packages here:

... or something like that.

I think it would also be great to roll this code into the main repo, if possible.