search

njlyon0 / dndR

Dungeons & Dragons Functions for Players and Dungeon Masters
https://njlyon0.github.io/dndR/
Other
17 stars 2 forks source link

I feel like there should be a d2 and a d3 dice in `roll()` #10

Closed wadedismukes closed 1 year ago

njlyon0 commented 1 year ago

Hm, "d2" is an accepted argument of roll already but what would you use a d3 for?

Also, I've considered just allowing any number of dice sides including weird dice (e.g., d17, etc.), do you think that would be helpful or should it be left as a discrete set of allowed dice?

wadedismukes commented 1 year ago

I run into "roll a d3" on a table in a book. I do not think all dice sides should be allowed (no one is rolling d17).

njlyon0 commented 1 year ago

roll will now accept any number of three-sided dice (i.e., "d3" where the "" is a number up to 10,000,000)! I've also added a show_dice argument to the roll function. If set to TRUE (defaults to FALSE) it will message all of the individual rolls included in the total value.

I've updated the pkgdown site, NEWS.md and the README with these tweaks and everything looks functional on my end. Ping me if you have issues but otherwise I'm marking this as complete 😄