njmango / sales-bot

0 stars 2 forks source link

Price modifier format #9

Open mcmcford opened 2 months ago

mcmcford commented 2 months ago

Currently there is no way to specify a non-relative price, which may not be very intuitive for people unfamiliar with the bot, As such it may be worth considering prefixes for relativity.

A percentage sign following the modifier shows perfectly well that the sellers’ or buyers’ price is x% relative to market price; That is perfect. However, if a user puts in a price modifier with no symbols, it is simply added on top of the current market price. It seems logical to use +0.05, -0.05 etc when it is clear that the variable is a price modifier. But, that is only mentioned in the help info. Slash commands would show that it is indeed a modifier whenever a user goes to type in a number but until then UX should be considered.

One way to go about this would be to enforce the use of symbols for prices relative to market price and the use of no symbols for a hard-set price. But, once again UX; people who are now becoming familiar with the bot know that they don’t need to put a +0.01 to sell at MP+0.01 they can simply type 0.01. So a way to keep that functionality but allow for non-relative prices would be to see if the users price modifier is within ~20% of the market price. Examples below help convey this concept.

MP of Q3 Power: 0.246, Current Behaviour:

Resource Quality MP User input ("modifier") Relative Result
Power Q3 0.246 -2% MP-2% 0.241
Power Q3 0.246 -0.015 MP-0.015 0.231
Power Q3 0.246 +0.005 MP+0.005 0.251
Power Q3 0.246 0.240 MP+0.240 0.486
Desired Behaviour: Resource Quality MP User input ("modifier") Relative Result
Power Q3 0.246 0.240 N/A 0.240
Power Q3 0.246 0.248 N/A 0.248

Selling above MP is an unlikely edge case however this can certainly be an improvement for people setting non-relative prices below MP

Logic table

Resource Quality MP User input ("modifier") Within 20% of MP? Conclusion Result
Power Q3 0.246 0.241 2%, Yes Static 0.241
Power Q3 0.246 0.115 53%, No Relative 0.361
Power Q3 0.246 -0.01 N/A, Has symbol Relative 0.236
Power Q3 0.246 0.225 8.5%, Yes Static 0.225
Power Q3 0.246 +0.004 N/A, Has symbol Relative 0.25
Power Q3 0.246 2% N/A, Has symbol Relative 0.251
Power Q3 0.246 -2.5% N/A, Has symbol Relative 0.240