Using deprecated constants as of 2024.1

bakerkj commented 10 months ago

System Health details

Core: 2024.1.0
Supervisor: 2023.12.0
Operating: System 11.2
Frontend: 20231208.2

Checklist

[ ] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue

Warnings from hass_traeger:

[homeassistant.const] TEMP_CELSIUS was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please create a bug report at https://github.com/njobrien1006/hass_traeger/issues
[homeassistant.const] TEMP_FAHRENHEIT was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.FAHRENHEIT instead, please create a bug report at https://github.com/njobrien1006/hass_traeger/issues
[homeassistant.components.climate.const] HVAC_MODE_COOL was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.COOL instead, please create a bug report at https://github.com/njobrien1006/hass_traeger/issues
[homeassistant.components.climate.const] HVAC_MODE_HEAT was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please create a bug report at https://github.com/njobrien1006/hass_traeger/issues
[homeassistant.components.climate.const] HVAC_MODE_OFF was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please create a bug report at https://github.com/njobrien1006/hass_traeger/issues
[homeassistant.components.climate.const] SUPPORT_PRESET_MODE was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.PRESET_MODE instead, please create a bug report at https://github.com/njobrien1006/h
ass_traeger/issues
[homeassistant.components.climate.const] SUPPORT_TARGET_TEMPERATURE was used from traeger, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please create a bug report at https://github.com/
njobrien1006/hass_traeger/issues

Reproduction steps

Initially running Home Assistant 2023.12.4 with hass_traeger 2023.10.06.01
Upgrade to Home Assistant 2024.1
Observe home-assistant.log

njobrien1006 commented 10 months ago

Thank you for the report. I'm still on 2023.12.3 and didn't have any of those.

It would appear they all came with 2023.12.4 on Dec-28-2023. If you'd like you can submit a PR for resolution against DEV branch otherwise, I'll evaluate as time permits.

njobrien1006 commented 10 months ago

Blog Refs: blog/2022/04/02/support-constants-deprecation blog/2022/05/03/constants-deprecations blog/2022/10/26/new-unit-enumerators

Code Examples: homeassistant/components/yolink/climate.py#L74-L79 homeassistant/components/yolink/climate.py#L81-L85 homeassistant/components/yolink/climate.py#L70

tmack8001 commented 10 months ago

@njobrien1006 this looks to be a duplicate of https://github.com/njobrien1006/hass_traeger/issues/59 which it seems you are addressing already in a DEV branch build. This specific issue should be able to be closed as duplicate.

njobrien1006 commented 10 months ago

I wasn't certain how to classify it. I found it similar but different (as there are 3 different blog entries) and just left it open as the fix is currently in DEV-Branch (Beta-Released) awaiting testing.

bakerkj commented 10 months ago

@njobrien1006 thanks for this fix!!

njobrien1006 / hass_traeger