search

njosefbeck / gatsby-source-stripe

Gatsby source plugin for building websites using Stripe as a data source
74 stars 17 forks source link

Support Node 8 #38

Closed KyleAMathews closed 5 years ago

KyleAMathews commented 5 years ago

Could you change your package.json engines to support the same versions as Gatsby e.g. 6+? Or at least 8+

Many people don't have Node 10 installed still so this plugin will break for them.

KyleAMathews commented 5 years ago

Many hosting providers also still default to node 8.

njosefbeck commented 5 years ago

Yeah, should be as simple as updating the engines and verifying that Babel properly transforms our use of for-await-of. Will get to it as soon as we can!

KyleAMathews commented 5 years ago

Thanks!

On Tue, May 21, 2019, 5:31 PM Nathan Beck notifications@github.com wrote:

Yeah, should be as simple as updating the engines and verifying that Babel properly transforms our use of for-await-of. Will get to it as soon as we can!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/njosefbeck/gatsby-source-stripe/issues/38?email_source=notifications&email_token=AAARLB2B4C5EKYUHQEFAV7TPWSH7JA5CNFSM4HN3RXOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV5R2RA#issuecomment-494607684, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARLBZFANOZR7DQ37SU5BTPWSH7JANCNFSM4HN3RXOA .

njosefbeck commented 5 years ago

This should now be taken care of with our 3.0.0 release. Thanks for the heads up Kyle 👍 .