search

njosefbeck / gatsby-source-stripe

Gatsby source plugin for building websites using Stripe as a data source
74 stars 17 forks source link

Download files for Prices' Products #61

Closed brxck closed 3 years ago

brxck commented 4 years ago

Hey, hope you are doing well!

Very small change to enable downloading of images in the expanded products field of the Price type. This is the same as doing it for the Sku type.

I marked this as WIP because I wanted to know your opinion on if/how the tests and the extractSkuUrls name should change to accommodate this.

njosefbeck commented 4 years ago

Hi! Nice to hear from you!

I guess we could rename the extractSkuUrls to be more generic, i.e. extractUrls ? I'd have to look at the tests again to see how they might need to change, but whatever you think is best I'll probably agree with!

clemgrim commented 4 years ago

hello @njosefbeck, any updates on this? Thank you!

njosefbeck commented 4 years ago

@brxck If you want to make the above name changes, I can merge this this weekend!

@clemgrim once brxck makes the above changes, I'll work on getting this merge and published to npm. Might still be a couple weeks, depending on schedules, etc. Appreciate your patience!

michalien commented 4 years ago

Hi @njosefbeck - any update? Many thanks, Mike

njosefbeck commented 4 years ago

@michalien no updates on my end! @brxck any updates on your end?

brxck commented 4 years ago

Unfortunately not! To copy from the other issue:

Sorry for the delay, but as things currently stand I'll be unable to make any changes for some time.

Please feel free to make any changes required to get this merged.

brxck commented 3 years ago

@njosefbeck please take a look when you can.

extractSkuUrls has become extractChildUrls, since extractUrls already exists.

Prices/Skus are identically shaped for the purpose of grabbing images, so tests have just been modified to swap out the object type in order to test both.

brxck commented 3 years ago

Nice timing! I'm catching up on a lot so I'll leave deps to you. Thanks!