search

njouanin / hbmqtt

MQTT client/broker using Python asynchronous I/O
MIT License
800 stars 188 forks source link

python3.7 support #139

Closed gdraynz closed 6 years ago

gdraynz commented 6 years ago

This will fix usage of hbmqtt on python3.7 (async now being a reserved python keyword). The asyncio.ensure_future method already exists in python3.4.4 so the asyncio.async method should not be necessary anymore.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at ?% when pulling 1afbe421e6abc79f43a5d22cc51d056eda60e5b2 on gdraynz:py37 into 945ab6e2fdc8301a38f8ad64735bd5097352a9ba on beerfactory:master.

njouanin commented 6 years ago

May be you can add python 3.7 environment in .travis.yml so we can check if tests are passing.

gdraynz commented 6 years ago

https://docs.travis-ci.com/user/languages/python/#Development-releases-support I'm not familiar with travis but I guess that will wait then. :<

balloob commented 6 years ago

@gdraynz here is an example on how to add Python 3.7 to Travis https://github.com/home-assistant/netdisco/pull/200/files

gdraynz commented 6 years ago

Nice thanks, i'll try fixing this in a bit then :)

gdraynz commented 6 years ago

Looks like the websockets library is not yet ready for 3.7. (See this commit and this issue).

balloob commented 6 years ago

Looks like it has been fixed in websockets: https://github.com/aaugustin/websockets/pull/438