njouanin / hbmqtt

MQTT client/broker using Python asynchronous I/O
MIT License
800 stars 188 forks source link

do actually wait for the connection in the mqtt_connection decorator #154

Closed burnpanck closed 5 years ago

burnpanck commented 5 years ago

This small bug probably doesn't trigger too often, which is probably also why it had been missed.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling bffed55a174eefb1bfb8bea75eaaf4e31035b679 on burnpanck:bugfix/await-asyncio.wait-in-mqtt-connected into 7704170d1d0772b9f506716bda00b559d2a44e48 on beerfactory:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling bffed55a174eefb1bfb8bea75eaaf4e31035b679 on burnpanck:bugfix/await-asyncio.wait-in-mqtt-connected into 7704170d1d0772b9f506716bda00b559d2a44e48 on beerfactory:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling bffed55a174eefb1bfb8bea75eaaf4e31035b679 on burnpanck:bugfix/await-asyncio.wait-in-mqtt-connected into 7704170d1d0772b9f506716bda00b559d2a44e48 on beerfactory:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling bffed55a174eefb1bfb8bea75eaaf4e31035b679 on burnpanck:bugfix/await-asyncio.wait-in-mqtt-connected into 7704170d1d0772b9f506716bda00b559d2a44e48 on beerfactory:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling bffed55a174eefb1bfb8bea75eaaf4e31035b679 on burnpanck:bugfix/await-asyncio.wait-in-mqtt-connected into 7704170d1d0772b9f506716bda00b559d2a44e48 on beerfactory:master.

wadetb commented 5 years ago

I just updated to latest hbmqtt and this bug broke my app, until I patched client.py in site-packages with this fix.

d21d3q commented 5 years ago

Is this PR planned to be merged?