search

njouanin / hbmqtt

MQTT client/broker using Python asynchronous I/O
MIT License
795 stars 188 forks source link

WIP: refactor to comply python3.8 and python3.9 #226

Open HerrMuellerluedenscheid opened 3 years ago

resingm commented 3 years ago

Great to see, that someone's working on a compatible version for Python versions >3.8. Any updates regarding this PR?

HerrMuellerluedenscheid commented 3 years ago

I'm on vacation til the end of the week and will hopefully find the time to look into this next week. A few additional errors were raised within the unit test which I need to have a closer look at.

pavandv commented 3 years ago

Hey, just curious.. I'm eagerly waiting for this PR to be merged.. Is the PR ready to be merged?? Thanks

HerrMuellerluedenscheid commented 3 years ago

It's not ready, yet. The tests do not succeed yet because of previously introduced hiccups that need to be resolved on master beforehand, I guess.

HerrMuellerluedenscheid commented 3 years ago

Depends on #231

HerrMuellerluedenscheid commented 3 years ago

Tests pass for python 3.6, 3.7, 3.8 and 3.9 after reverting as discussed in #231. https://travis-ci.org/github/beerfactory/hbmqtt/builds/753846602. Still, I would like to have #231 resolved to build on solid grounds.

pavandv commented 3 years ago

Hey @HerrMuellerluedenscheid is this PR ready to be merged? I saw your other PR's (#228, #229) and Issue (#235) & I don't think @njouanin is ready to act on those..

If this PR is ready I would like to merge this into my own Fork.. Thanks.

HerrMuellerluedenscheid commented 3 years ago

Hey @HerrMuellerluedenscheid is this PR ready to be merged? I saw your other PR's (#228, #229) and Issue (#235) & I don't think @njouanin is ready to act on those..

If this PR is ready I would like to merge this into my own Fork.. Thanks.

Hey @pavandv , No, it's not ready. I mean tests pass but I reverted a commit by @shipmints in this MR just to get the CI running. Thus, this MR now additionally depends on #236 to restore what @shipmints fixed. We need feedback/approval/merge by @njouanin.

pavandv commented 3 years ago

Hey @HerrMuellerluedenscheid as this is not maintained anymore, what is the status on this??

FlorianLudwig commented 3 years ago

@pavandv hey,

i continued the branch there: https://github.com/Yakifo/aio-hbmqtt/pull/18

it does not contain changes compared to this branch for the actual code, just tests.